1037686 - Remove js_strdup, replace with UniquePtr-returning method

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

There are sufficiently few users we should just do this.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Change a bunch of users to use a new DuplicateString overload

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Convert ScriptSource::{filename,introducerFilename}_ to UniquePtr, make !introducerFilename_ formally imply filename_

I *think* the current ownership model lets us make this change basically trivially, unless I'm missing some quirkiness.

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Remove js_strdup now that no one uses it

Comment 4

[Jim Blandy :jimb]

Comment on attachment 8454722 [details] [diff] [review]
Change a bunch of users to use a new DuplicateString overload

Review of attachment 8454722 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Jim Blandy :jimb]

Comment on attachment 8454724 [details] [diff] [review]
Convert ScriptSource::{filename,introducerFilename}_ to UniquePtr, make !introducerFilename_ formally imply filename_

Review of attachment 8454724 [details] [diff] [review]:
-----------------------------------------------------------------

I can't see anything wrong with this.

::: js/src/jsscript.cpp
@@ +1765,4 @@
>          info->uncompressed += mallocSizeOf(uncompressedChars());
>      else if (dataType == DataCompressed)
>          info->compressed += mallocSizeOf(compressedData());
> +    info->misc += mallocSizeOf(this) + mallocSizeOf(filename_.get());

Ignoring introducerFilename_ here is an existing bug, but since you've made introducerFilename_ and filename_ never share storage, you might consider addressing it now and including mallocSizeOf(introducerFilename_.get()) in the count.

Comment 6

[Jim Blandy :jimb]

Comment on attachment 8454726 [details] [diff] [review]
Remove js_strdup now that no one uses it

Review of attachment 8454726 [details] [diff] [review]:
-----------------------------------------------------------------

What could go wrong?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0df559de573e
https://hg.mozilla.org/mozilla-central/rev/91ebfb14db1d
https://hg.mozilla.org/mozilla-central/rev/f08ebff1dd5a
https://hg.mozilla.org/mozilla-central/rev/ff595341b34f