103774 - Incorrect expiration date in the Cert selection dialog

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Antonio Lam]

Build used: 2001-10-08-05-0.9.4

In the certificate selection dialog used for client authentication, the "Valid 
from" field has a wrong date (using the issued date as the expired date)

  Valid from 6/4/01 14:59:02 PM to 6/4/01 14:59:02 PM

The correct validity of the cert should be: (from Certificate Manager)

Issued On: 6/4/01
Expires On: 12/1/01

Comment 1

[Stephane Saux]

->kai.

Comment 2

[Antonio Lam]

Attachment: Cert selection dialog screenshot

Comment 3

[John Unruh]

Confirmed for certificate selection dialog. Adding relnote keyword.

Comment 4

[Kai Engert (:KaiE:)]

Attachment: Suggested fix, replacing wrong function call

Comment 5

[Kai Engert (:KaiE:)]

I think the bug description should be updated. As I understand it, the "from"
date is displayed correct. However, the "expires" date is displayed incorrectly.

The above patch corrects the code to display the correct expires date.

Comment 6

[Antonio Lam]

My original thought is the "Valid From" field in the Cert dialog has the 
incorrect information.

Updated bug summary to reflet the expiration date to make it more clear.

Comment 7

[Javier Delgadillo]

r=javi

Comment 8

[Bob Lord]

Let's get this on the trunk soon.

Comment 9

[Stephane Saux]

Comment on attachment 52737 [details] [diff] [review]
Suggested fix, replacing wrong function call

has-review as per javi.

Comment 10

[Stephane Saux]

adding patch, review keywords.

Comment 11

[Christopher Blizzard (:blizzard)]

Comment on attachment 52737 [details] [diff] [review]
Suggested fix, replacing wrong function call

rs=blizzard

Comment 12

[Kai Engert (:KaiE:)]

Checked in to trunk.

Comment 13

[John Unruh]

Verified on Win98 10/12 trunk build. Can this be checked into the branch?

Comment 14

[John Unruh]

Verified.