Remove import of the unused FileUtils.jsm from WebappRT.jsm

RESOLVED FIXED in Firefox 33

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: marco, Assigned: lviknesh, Mentored)

Tracking

Trunk
Firefox 33

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

The relevant file is http://mxr.mozilla.org/mozilla-central/source/webapprt/WebappRT.jsm

We're lazily importing FileUtils, but never using it. We should remove it.
Assignee: nobody → lviknesh
Status: NEW → ASSIGNED
Attachment #8454928 - Flags: review?(mar.castelluccio)
Comment on attachment 8454928 [details] [diff] [review]
webappRT.patch

Review of attachment 8454928 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
This shouldn't cause any problem, but FYI you can run tests for the webapp runtime via the following mach commands:
1) ./mach webapprt-test-chrome
2) ./mach webapprt-test-content
3) ./mach mochitest-chrome toolkit/webapps/
Attachment #8454928 - Flags: review?(mar.castelluccio) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f1e4fe6d3fc7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.