Closed
Bug 1037741
Opened 10 years ago
Closed 10 years ago
Remove import of the unused FileUtils.jsm from WebappRT.jsm
Categories
(Firefox Graveyard :: Webapp Runtime, defect)
Firefox Graveyard
Webapp Runtime
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: marco, Assigned: lviknesh, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
|
1000 bytes,
patch
|
marco
:
review+
|
Details | Diff | Splinter Review |
The relevant file is http://mxr.mozilla.org/mozilla-central/source/webapprt/WebappRT.jsm We're lazily importing FileUtils, but never using it. We should remove it.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → lviknesh
Status: NEW → ASSIGNED
Attachment #8454928 -
Flags: review?(mar.castelluccio)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8454928 [details] [diff] [review] webappRT.patch Review of attachment 8454928 [details] [diff] [review]: ----------------------------------------------------------------- Thank you! This shouldn't cause any problem, but FYI you can run tests for the webapp runtime via the following mach commands: 1) ./mach webapprt-test-chrome 2) ./mach webapprt-test-content 3) ./mach mochitest-chrome toolkit/webapps/
Attachment #8454928 -
Flags: review?(mar.castelluccio) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1e4fe6d3fc7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f1e4fe6d3fc7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•