1037748 - Try to combine PuppetScreenManager and nsScreenManagerProxy, or PuppetScreenManager and nsScreenManagerAndroid

Status: RESOLVED INVALID

(Core :: DOM: Content Processes, defect, P4)

Description

[Mike Conley (:mconley) (:⚙️)]

PuppetScreenManager and nsScreenManagerProxy sort of do the same things - namely, fake out the nsIScreenManager for the content process.

PuppetScreenManager is, however, specialized for b2g, whereas nsScreenManagerProxy is for... well, almost everybody else (Firefox Desktop for Windows, OS X, Linux).

To complicate things further, Android uses its own nsScreenManagerAndroid that does something similar to both PuppetScreenManager and nsScreenManagerProxy.

There's probably some room for de-duplication here. Combining PuppetScreenManager and nsScreenManagerAndroid seems attractive because, at least at this point in time, most mobile devices don't worry about multiple displays - whereas this is something far more common in the desktop world.

Anyhow, it seemed like a thing we might want to do at some point.

Comment 1

[Jens Stutte [:jstutte]]

I cannot find PuppetScreenManager or nsScreenManagerProxy in today's codebase. In bug 1194751 we did some work for ScreenManager which seems to be the only child of nsIScreenManager these days.

Feel free to re-open if I misread something.