Closed Bug 1037751 Opened 10 years ago Closed 10 years ago

Use white graphics for the phishing icon

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird34 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 34.0
Tracking Flags:
Tracking Status
thunderbird34 --- fixed

People

(Reporter: jsbruner, Assigned: jsbruner)

Details

Attachments

(1 file, 2 obsolete files)

Patch.
3.93 KB, patch
Paenglab
: review+
Details | Diff | Splinter Review
Attached patch Patch. (obsolete) — — Splinter Review 
We're using a black phishing graphic which is very hard to see on the new red notification bars. Let's switch to white.
Attachment #8454841 - Flags: review?(richard.marti)
Comment on attachment 8454841 [details] [diff] [review]
Patch.

The icon looks good, maybe less transparent would look better.

Please can you apply this also to XP and Linux? Both are also using the red notification.

And could you also change http://mxr.mozilla.org/comm-central/source/mail/themes/windows/mail/messenger.css#149 to notification[type="critical"] .messageCloseButton:not(:hover):not(:active)? Then the close button becomes a white cross and is better visible.
Attachment #8454841 - Flags: review?(richard.marti)
Attached patch Patchl (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch.
        — 
          — Splinter Review
      

    


  
There we go. Made the changes.

        Attachment #8454841 -
        Attachment is obsolete: true

        Attachment #8458358 -
        Attachment is obsolete: true

        Attachment #8458359 -
        Flags: review?(richard.marti)

    
    

    
  
Comment on attachment 8458359 [details] [diff] [review]
Patch.

Looks good. Thank you.

        Attachment #8458359 -
        Flags: review?(richard.marti) → review+

    
  
Keywords: checkin-needed

    
  
Summary: Use white graphics for phishing icon on Win Aero and OS X. → Use white graphics for the phishing icon

    
    

    
  
https://hg.mozilla.org/comm-central/rev/9a79c678424d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0

    
  
Flags: in-testsuite-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: