bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Move cloneSingletons to CompartmentOptions

RESOLVED FIXED in mozilla33

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Right now this thing is set up as a per-compartment override of a per-context default, but nobody ever changes the default on the context. That makes this very easy to fix.
(Assignee)

Comment 1

4 years ago
Created attachment 8455488 [details] [diff] [review]
Move cloneSingletons to CompartmentOptions. v1
Attachment #8455488 - Flags: review?(jdemooij)
Comment on attachment 8455488 [details] [diff] [review]
Move cloneSingletons to CompartmentOptions. v1

Review of attachment 8455488 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.h
@@ +2597,5 @@
>          return *this;
>      }
>  
>  
> +    bool cloneSingletons(JSContext *cx) const { return cloneSingletons_; }

Remove the |cx| argument, r=me with that.
Attachment #8455488 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/3b0111ca90e2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.