Closed
Bug 1037775
Opened 10 years ago
Closed 10 years ago
Port |bug 1036864 - Remove EXPORT_LIBRARY| to MailNews
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 33.0
People
(Reporter: ewong, Assigned: ewong)
References
Details
Attachments
(2 files, 1 obsolete file)
3.19 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
4.56 KB,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1036864 +++ EXPORT_LIBRARY was used to copy libraries in $(DEPTH)/staticlib. We don't use that anymore. The only use outside that was to export gkmedias to $(DIST)/lib, and it's not required there as long as libxul links with the right location.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8454870 -
Flags: review?(Pidgeot18)
Comment 2•10 years ago
|
||
Comment on attachment 8454870 [details] [diff] [review] Port patch (v1) Review of attachment 8454870 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=Standard8
Attachment #8454870 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/540e02fd3123
Comment 4•10 years ago
|
||
I just had this patch in a tryserver run to get the builds working again. On MacOSX, the builds failed with the following message: > ld: symbol(s) not found for architecture i386 > clang: error: linker command failed with exit code 1 (use -v to see invocation) > make[11]: *** [libprldap60.dylib] Error 1 > make[10]: *** [export] Error 2 > make[9]: *** [export] Error 2 > make[8]: *** [export] Error 2 > make[7]: *** [libs] Error 2 > make[6]: *** [../ldap/libs] Error 2 > make[5]: *** [libs] Error 2 > make[4]: *** [default] Error 2 > make[3]: *** [default] Error 2 > make[2]: *** [build] Error 2 > make[1]: *** [build] Error 2 > make: *** [build] Error 2 Since the ldap-makefile is changed by this patch I thought there might be a connection. You can see the tryserver build here: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=c9f909cc92e5
Comment 5•10 years ago
|
||
Verified fixed, at least for windows on a local build of TB Thanks ewong.
Comment 6•10 years ago
|
||
More removes and cleanup of EXPORT_LIBRARY in comm-central files may be required. https://mxr.mozilla.org/comm-central/search?string=EXPORT_LIBRARY&case=on
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Takanori MATSUURA from comment #6) > More removes and cleanup of EXPORT_LIBRARY in comm-central files may be > required. > https://mxr.mozilla.org/comm-central/search?string=EXPORT_LIBRARY&case=on Will a patch up asap. Thanks
Assignee | ||
Comment 8•10 years ago
|
||
The line that I'm not sure of is the last mention of EXPORT_LIBRARY in rules.mk.
Attachment #8455073 -
Flags: review?(Pidgeot18)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8455073 [details] [diff] [review] More EXPORT_LIBRARY removals. This is for the calendar/ review (even though it is just a comment removal). Just want to be sure.
Attachment #8455073 -
Flags: review?(philipp)
Updated•10 years ago
|
Attachment #8455073 -
Flags: review?(philipp) → review+
Comment 10•10 years ago
|
||
Comment on attachment 8455073 [details] [diff] [review] More EXPORT_LIBRARY removals. Review of attachment 8455073 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/rules.mk @@ +379,5 @@ > ifndef MODULE_NAME > $(error MODULE_NAME is required for components which may be used in static builds) > endif > endif > endif This entire block can go (MODULE_NAME is dead as a doornail). @@ +572,1 @@ > endif # LIBRARY_NAME This entire block can probably go.
Attachment #8455073 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8455073 -
Attachment is obsolete: true
Attachment #8455880 -
Flags: review+
Assignee | ||
Comment 12•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/da9f7e5e18b2
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → Thunderbird 33.0
You need to log in
before you can comment on or make changes to this bug.
Description
•