Closed Bug 1037820 Opened 5 years ago Closed 5 years ago

[Nexus S] Remove the SensorsListener hack

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S6 (18july)

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

In bug 871916 we introduced SensorsListener as a workaround for some devices (namely Nexus S).

It's visible at: http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#1240

The rationale was that without this hack we were not able to get any devicemotion event properly. At the time of this hack, without, we would get devicemotion events but with improper values. I have been reevaluating this recently, and it seems that it's not needed anymore. My dogfooding Nexus S has been running properly and getting correct devicemotion handling for a few weeks with this code reverted.

Since it's a hack, designed for this only device, I propose that we shoot this.
Fabrice, please find attached a patch that removes this listener. I don't have any issue at all using it on my Nexus S since I've applied it, rotation works well on my device, and moreover I've noticed a slight improvement in reactivity and battery.
Attachment #8454894 - Flags: review?(fabrice)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S6 (18july)
Attachment #8454894 - Flags: review?(fabrice) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8c62d9b5f1af
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.