1037820 - [Nexus S] Remove the SensorsListener hack

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

In bug 871916 we introduced SensorsListener as a workaround for some devices (namely Nexus S).

It's visible at: http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#1240

The rationale was that without this hack we were not able to get any devicemotion event properly. At the time of this hack, without, we would get devicemotion events but with improper values. I have been reevaluating this recently, and it seems that it's not needed anymore. My dogfooding Nexus S has been running properly and getting correct devicemotion handling for a few weeks with this code reverted.

Since it's a hack, designed for this only device, I propose that we shoot this.

Comment 1

[:gerard-majax]

Attachment: 0001-Bug-1037820-Remove-SensorsListener-hack.patch

Fabrice, please find attached a patch that removes this listener. I don't have any issue at all using it on my Nexus S since I've applied it, rotation works well on my device, and moreover I've noticed a slight improvement in reactivity and battery.

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8c62d9b5f1af

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c62d9b5f1af