1037864 - [GaiaGrid] Serve localization from within the gaia grid component

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

It's more clear when the locale files come from the component. Let's do the same thing we did in the menu, and serve the files from the component folder.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8454917 [details] [review]
Github pull request

Cristian could you take a look at this? Note: to successfully test this, you would also need the patch from bug 1032261. (I think I would like to land them together to standardize on a solution).

Thanks!

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8454917 [details] [review]
Github pull request

LGTM, just a comment in github

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Kevin, we ready to land this bad boy?

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Michael Henretty [:mhenretty] from comment #4)
> Kevin, we ready to land this bad boy?

I was kind of waiting to see what the web components land would look like, but since we have some more coming, and you asked - let's do it :)

Comment 6

[Kevin Grandon :kgrandon]

Waiting for bug 1032261 to re-run on CI then will land this as there is a dependency.

Comment 7

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/c64391365de44f9e531af24c900cfea09f0b8eaa

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

I think there's a regression from this patch. The path in locales.ini should be relative to its location.

Right now this: https://github.com/mozilla-b2g/gaia/blob/add5d975a7e0028d9787e5beb8346ac94ba60c34/shared/elements/gaia_grid/locales/locales.ini points to non existing dir shared/elements/gaia_grid/locales/gaia_grid/gaia_grid.{locale}.properties

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Pull request - Follow-up, fix property file paths

Thanks for noticing Zibi!

Going to give this a test run, and if it looks alright I'll flag you for review if that's ok.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8465019 [details] [review]
Pull request - Follow-up, fix property file paths

Hey Zibi - verified that the strings work with the test locales. Wanted to flag you for review to make sure we're doing the right thing here. Thanks as always.

Comment 11

[Kevin Grandon :kgrandon]

Thank you! In master: https://github.com/mozilla-b2g/gaia/commit/d99d86a8cfe6eec49129b0c08cdc417c4b2f1721