Closed Bug 1037871 Opened 7 years ago Closed 7 years ago

Enable Latin1 strings by default

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
relnote-firefox --- 33+

People

(Reporter: jandem, Assigned: jandem)

References

Details

(Whiteboard: [MemShrink])

Attachments

(1 file)

Attached patch PatchSplinter Review
With the patch in bug 1037869 I have a green Linux64 Try run, so this seems to work (will do an all-platforms Try push before landing this of course):

https://tbpl.mozilla.org/?tree=Try&rev=2f996243f96b

If this sticks, we can remove the EnableLatin1Strings flag in the next cycle (and remove a bunch of dead code).
Attachment #8454920 - Flags: review?(luke)
Comment on attachment 8454920 [details] [diff] [review]
Patch

whoa, bravo good sir!
Attachment #8454920 - Flags: review?(luke) → review+
All-platforms Try push:

https://tbpl.mozilla.org/?tree=Try&rev=355bc14ee46d

Fingers crossed..
https://hg.mozilla.org/integration/mozilla-inbound/rev/46b4e732a72e

Also bumped XDR_BYTECODE_VERSION, just in case.
https://hg.mozilla.org/mozilla-central/rev/46b4e732a72e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Whiteboard: [MemShrink]
relnote-firefox: --- → ?
Added to the release notes with "Slimmer and faster JavaScript strings (learn more)" as wording.
learn more pointing to https://blog.mozilla.org/javascript/2014/07/21/slimmer-and-faster-javascript-strings-in-firefox/
You need to log in before you can comment on or make changes to this bug.