Closed Bug 1037883 Opened 10 years ago Closed 6 years ago

mozconfigs can not find buildprops.json when builds are through mozharness

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jlund, Unassigned)

References

Details

it looks like for windows builds we are setting --with-ccache

taking a look at mozconfigs, thithis is because $platform is getting non in mozconfig.cache so the 'win*' condition fails to catch.

The reason platform is not have any value is because the mozconfigs can't find buildprops.json: http://mxr.mozilla.org/mozilla-central/source/build/mozconfig.cache#11 as the relative path to buildprops has changed in mozharness:

buildbot legacy build src path:
c:/builds/moz2_slave/m-cen-w32-ntly-000000000000000/build/

mozharness build src path:
c:/builds/moz2_slave/m-cen-w32-ntly-000000000000000/build/src

Possible solutions:

(1) add an extra search path. i.e.:
 '$topsrcdir"'/../../buildprops.json'

(2) remove need for buildprops.json and put platform, branch, etc in the env itself.

(3) get mozharness to copy buildprops.json and puts it one dir deeper so mozconfig.cache finds it where it is expected to be. 

all three solutions are not very clean though. I have done (3) to just get by. I would lean towards (2) but I'm cautious of flooding env. I should also point out that the goal is to remove buildbot legacy builds and do-all-the-things via mozharness and also to remove buildprops.json. Once either of those happen, this doesn't really matter.
Product: Core → Firefox Build System
we have no more buildprops.json
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.