1037947 - Fix test_movemailDownload.js to work with maildir

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Suyash Agarwal (:sshagarwal)]

We intend to make test_movemailDownload.js to pass with both
mbox and maildir mailbox formats.

Comment 1

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1

nsIInputStream wasn't needed in nsMovemailService::GetNewMail()
so I removed it.
Also maybe because movemailspool is just an mbox format file.
So, I thought to firstly create another movemailspool directory in maildir
format. But then this works as is.
Please let me know the changes/modifications I am supposed to make in this.

Thanks.

Comment 2

[Kent James (:rkent)]

Comment on attachment 8454994 [details] [diff] [review]
Patch v1

Review of attachment 8454994 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good except for the two issues (using the store list from localAccountsUtils, and clearing the hdr array). r=me with these two issues fixed.

::: mailnews/local/src/nsMovemailService.cpp
@@ +512,1 @@
>        rv = newMailParser->Init(serverFolder, inbox,

Just a note for future reference:

The inputStream was added in bug #748726 without any comment. I cannot think of any valid reason why this QI to an unused variable makes sense. I'm going to assume this was just some leftover stray code, and that the removal here makes sense.

::: mailnews/local/test/unit/test_movemailDownload.js
@@ +6,5 @@
>  Components.utils.import("resource://gre/modules/Services.jsm");
>  Components.utils.import("resource://gre/modules/Task.jsm");
>  Components.utils.import("resource://testing-common/mailnews/PromiseTestUtils.jsm");
>  
> +var gPluggableStores = [

Isn't this in localAccountUtils now? Just use the version from there.

@@ +55,5 @@
> +    var msgCount = 0;
> +    let hdr;
> +    while (enumerator.hasMoreElements()) {
> +      let hdr = enumerator.getNext().QueryInterface(Ci.nsIMsgDBHdr);
> +      gMsgHdrs.push(hdr);

You run this code twice, once for each store. But the gMsgHdrs array only gets cleared in the overall initialization. So the second time that you run streamMessages, you restream the headers from the mbox test.

So you need to clear gMsgHdrs at the start of continueTest().

Comment 3

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch for check-in

Thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/74c23393fbbc