An exception is thrown if a user manually tries to access the /profile url when not logged in. This should be fixed.
Should have been `/profile/new/`
Summary: Error when accessing /profile when not logged in → Error when accessing /profile/new when not logged in
Created attachment 8455012 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/156 When reviewing this please verify the bug behaviour before applying the PR and then verify that the bug has been fixed with the PR.
Works fine and looks good. Just an optional change suggested on the pull. Please let me know if we can have that change or I will mark this r+.
Comment on attachment 8455012 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/156 Thanks for clarification Bob. It now looks good to me and works fine !!
Attachment #8455012 - Flags: review?(mozpankaj1994) → review+
Comment on attachment 8455012 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/156 Landed in https://github.com/mozilla/oneanddone/commit/83c2a39655b8d7ea6b90991dc466fa2f9e0ce4ad
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
I verified on staging that users are redirected to the home page when trying to access profile/new in a logged out state. How can I verify that errors were not added to the logs?
I don't think you can verify that. Errors are not written to logs, but rather I receive an email when an error occurs. One thing you could do, although it wouldn't be 100% accurate, would be to check New Relic  to see if it captured any errors during the period of your testing. I'm not too concerned about that verification though. The main issue is that the user should not be presented with an error page. You can check the current buggy behaviour on prod.  https://rpm.newrelic.com/accounts/263620/applications/3955000/traced_errors
There are no new errors listed in New Relic, and I'm assuming you didn't receive email [bsilverberg] from my testing. Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.