Closed Bug 1037976 Opened 6 years ago Closed 6 years ago

Enable some of the Iframe sandbox mochitests on b2g emulator

Categories

(Core :: Security, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

Details

Attachments

(1 file)

This is a follow-up from bug 904659.
It turns out that those mochitests don't crash anymore and they seem to pass on b2g emulator (on b2g desktop they time out).
See https://tbpl.mozilla.org/?tree=Try&rev=2992a3a6648b
Attached patch 1037976.diffSplinter Review
Assignee: nobody → martijn.martijn
Comment on attachment 8455018 [details] [diff] [review]
1037976.diff

Review of attachment 8455018 [details] [diff] [review]:
-----------------------------------------------------------------

Try server is green, I retriggered the try server a couple of times, to make sure there's no intermittent failure.
Attachment #8455018 - Flags: review?(jmaher)
Comment on attachment 8455018 [details] [diff] [review]
1037976.diff

Review of attachment 8455018 [details] [diff] [review]:
-----------------------------------------------------------------

great to see more tests being turned on.
Attachment #8455018 - Flags: review?(jmaher) → review+
Weird, I did call retrigger (some 20 times or so) of the mochitest run where these new tests would run in b2g emulator, but they don't show up anymore in the tryserver run. I know I had at least 5 green runs there (the other ones were still not finished at that time), so I think this is good enough to be checked in.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5de6a856c65a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.