1038055 - [prod][traceback] Error on login_failure()

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[John Giannelos [:nemo-yiannis]]

Traceback (most recent call last):

  File "/data/www/mozillians.org/mozillians/vendor/lib/python/django/core/handlers/base.py", line 113, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-2.16.0.12/newrelic/hooks/framework_django.py", line 492, in wrapper
    return wrapped(*args, **kwargs)

  File "/data/www/mozillians.org/mozillians/vendor/lib/python/django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)

  File "/data/www/mozillians.org/mozillians/vendor-local/src/django-browserid/django_browserid/views.py", line 97, in dispatch
    return super(Verify, self).dispatch(request, *args, **kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-2.16.0.12/newrelic/hooks/framework_django.py", line 829, in wrapper
    return wrapped(*args, **kwargs)

  File "/data/www/mozillians.org/mozillians/vendor/lib/python/django/views/generic/base.py", line 86, in dispatch
    return handler(request, *args, **kwargs)

  File "/data/www/mozillians.org/mozillians/mozillians/common/authbackend.py", line 70, in post
    return super(BrowserIDVerify, self).post(*args, **kwargs)

  File "/data/www/mozillians.org/mozillians/vendor-local/src/django-browserid/django_browserid/views.py", line 85, in post
    return self.login_failure(e)

TypeError: login_failure() takes exactly 1 argument (2 given)

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/bf5a67e3ee3936eaf16884f578bfb013a231206c
[Fix bug 1038055] Fix authentication login_failure() definition.

* Implement error handling.
* Fix login_failure() TypeError triggered by BrowserIDException on BrowserID post().

https://github.com/mozilla/mozillians/commit/29339965f6ea81d41a5005f74ad8f5f9b1395a7d
Merge pull request #1035 from johngian/fix-1038055

[Fix bug 1038055] Fix authentication login_failure() definition.

Comment 3

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-]. Post-release I have not seen these tracebacks again.