1038113 - [fi] Fennec 32 review notes

Status: RESOLVED FIXED

(Mozilla Localizations :: fi / Finnish, defect)

Description

[Jeff Beatty [:gueroJeff]]

Review of the most recent sign off for Fennec 32 shows some issues with region.properties in changeset 54e2a01a7b22. In updating region.properties to reflect changes in en-US, it added all the tiles keys, but also default search engines, which we need to avoid to retain your original productization choices for Finnish. Please be sure to file a bug and assign it to flod for future updates to region.properties.

As always, thank you for your efforts!

Comment 1

[Ville Pohjanheimo (inactive)]

Attachment: Region patch for FI

Attached a patch that should address the issues Jeff raised while updating region.properties to same state as en-US. Please review flod.

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8460082 [details] [diff] [review]
Region patch for FI

I assume this patch is for beta.

Can you please backout the change to region.properties on mozilla-aurora, and create a patch starting from that (good) status?

hg revert mobile/chrome/region.properties -r 5421393966c5
hg commit -m "Revert unapproved changes to mobile/region.properties"
hg push

The only part that I can accept at the moment is adding Yahoo as feed handler (browser.contentHandlers.types.0.*)

browser.suggestedsites.list.*
That's an "experimental" feature, and we're not localizing it for now. I'll send a message to dev-l10n as soon as I have more information, for now we're just falling back to en-US values.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #2)
> Can you please backout the change to region.properties on mozilla-aurora,
> and create a patch starting from that (good) status?
> 
> hg revert mobile/chrome/region.properties -r 5421393966c5
> hg commit -m "Revert unapproved changes to mobile/region.properties"
> hg push

I took care of this part since I needed to land other changes for productization
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/rev/5918fe1ff9f5

As I said, we can either mark this bug as fixed now that regression has been backed out, or add Yahoo as feed handler.

Comment 4

[Ville Pohjanheimo (inactive)]

Ok. Closed as it is.