Give LowEventsReporter a private destructor

RESOLVED FIXED in mozilla33

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8455312 [details] [diff] [review]
Give LowEventsReporter a private destructor
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 752004
(Assignee)

Updated

3 years ago
Attachment #8455312 - Flags: review?(bjacob)
Comment on attachment 8455312 [details] [diff] [review]
Give LowEventsReporter a private destructor

Review of attachment 8455312 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to r+ this even though I'm not at all an XPCOM peer, because I've gotten a lot of reviews recently for other similar patches and as far as XPCOM was concerned, there was no trouble getting reviews for such trivial patches. But just so you know, I've had tons of nitpicking on other dirs. I'll decline reviews as needed.
Attachment #8455312 - Flags: review?(bjacob) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Benoit Jacob [:bjacob] from comment #2)
> Comment on attachment 8455312 [details] [diff] [review]
> Give LowEventsReporter a private destructor
> 
> Review of attachment 8455312 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm going to r+ this even though I'm not at all an XPCOM peer, because I've
> gotten a lot of reviews recently for other similar patches and as far as
> XPCOM was concerned, there was no trouble getting reviews for such trivial
> patches. But just so you know, I've had tons of nitpicking on other dirs.
> I'll decline reviews as needed.

Please don't let those nits discourage you, I asked for your review because I trust your judgement on these patches more.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4625d8a9c9a
https://hg.mozilla.org/mozilla-central/rev/d4625d8a9c9a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.