Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

RESOLVED FIXED in mozilla33

Status

()

Core
XPCOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 752004
(Assignee)

Updated

4 years ago
Attachment #8455317 - Flags: review?(bjacob)
Comment on attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

Review of attachment 8455317 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see why the counting macros are useless here.
Attachment #8455317 - Flags: review?(bjacob) → review-
ISupports refcounting does the same thing as COUNT_CTOR/DTOR.
(Assignee)

Comment 4

4 years ago
Comment on attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

What mccr8 said.
Attachment #8455317 - Flags: review- → review?(bjacob)
Attachment #8455317 - Flags: review?(bjacob) → review+
One interesting thing is that I think if you are using a refcounted class improperly and never addref/release it, then you won't get leak tracking, so COUNT_CTOR is useful. But I think thanks to the work to hide dtors that shouldn't be as much of a problem any more.
https://hg.mozilla.org/mozilla-central/rev/164c1eef200a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.