Closed Bug 1038150 Opened 5 years ago Closed 5 years ago

Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: winclang
Attachment #8455317 - Flags: review?(bjacob)
Comment on attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

Review of attachment 8455317 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see why the counting macros are useless here.
Attachment #8455317 - Flags: review?(bjacob) → review-
ISupports refcounting does the same thing as COUNT_CTOR/DTOR.
Comment on attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

What mccr8 said.
Attachment #8455317 - Flags: review- → review?(bjacob)
Attachment #8455317 - Flags: review?(bjacob) → review+
One interesting thing is that I think if you are using a refcounted class improperly and never addref/release it, then you won't get leak tracking, so COUNT_CTOR is useful. But I think thanks to the work to hide dtors that shouldn't be as much of a problem any more.
https://hg.mozilla.org/mozilla-central/rev/164c1eef200a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.