Closed Bug 1038185 Opened 5 years ago Closed 5 years ago
Closing the notification panel has no transition
Closing the notification panel always makes it just instantly disappear. I'm working on master - I don't know if this is on 2.0 right now, but nominating it as a blocker as I suspect it is. Patch incoming.
Comment on attachment 8455353 [details] [review] Fix transition when closing utility tray I think the case where we have no transform still exists. IIRC when you just tap the status bar, no touchmove, so no transform set and no transitionend. Clearing the transform _after_ we check its value instead of before should do the trick though :)
Attachment #8455353 - Flags: review?(etienne) → review-
Qawanted to check if this is on 2.0.
This issue occurs on Flame 2.1, Flame 2.0, Flame 1.4, and Buri 2.0. Removing regression tag as this does not appear to be one. Environmental Variables: Device: Flame Master BuildID: 20140714061512 Gaia: 88e0a972280bb35847c010b8c3f1481fa80f3847 Gecko: 340b19c14d3d Version: 33.0a1 (Master) Firmware Version: v122 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Environmental Variables: Device: Flame 2.0 BuildID: 20140714113711 Gaia: f2509d29f7ee4d670d0dbc47f16e1794529aee3f Gecko: 8e9d3b4b52fd Version: 32.0a2 (2.0) Firmware Version: v122 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Environmental Variables: Device: Flame 1.4 BuildID: 20140711225112 Gaia: b7d36622c7df92c976c37520ccab25199c7ada91 Gecko: dbebcdab47aa Version: 30.0 (1.4) Firmware Version: v122 User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0 Environmental Variables: Device: Buri 2.0 BuildID: 20140714000202 Gaia: ca022f811bcbbda0f89086094a9e92bb220fea18 Gecko: 376889ab0e02 Version: 32.0a2 (2.0) Firmware Version: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 The notification tab goes away immediately without a transition.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Comment on attachment 8455353 [details] [review] Fix transition when closing utility tray Pull-request updated, suggested change made.
Attachment #8455353 - Flags: review- → review?(etienne)
Comment on attachment 8455353 [details] [review] Fix transition when closing utility tray Thanks!
Attachment #8455353 - Flags: review?(etienne) → review+
The fix for this bug caused a regression: bug 1038698
Caused a regression in test_a11y_utility_tray_visibility.py accessibility test: bug 1038698. Backed out: https://github.com/mozilla-b2g/gaia/commit/b90f476727f948cccfb8c46361ca5ab7c84ce001
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Carrying r+, very simple change so that the wheel event used to close the tray works in the same way as it did before this patch (close instantly). Will wait for green travis before merging again.
And merged again: https://github.com/mozilla-b2g/gaia/commit/686815a84bba448d3f04e3dca6f7949dca04d001 Second time lucky?
Chris, do you mind posting an interdiff patch that we can land on v2.0? AFAICT, the original push was never backed out there.
I just reverted and re-landed. v2.0: https://github.com/mozilla-b2g/gaia/commit/b5a7683318a42ac7ae00691fb0af7d4ebfc0e478
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #14) > I just reverted and re-landed. > v2.0: > https://github.com/mozilla-b2g/gaia/commit/ > b5a7683318a42ac7ae00691fb0af7d4ebfc0e478 thanks, this was next on my list but lost internet connectivity in Koln...
This issue has been verified successfully on Flame 2.0,2.1 See attachment: Verify_video.3gp Reproducing rate: 0/5 Flame2.0 build: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141127000203 Version 32.0 Flame2.1 build: Gaia-Rev 5372b675e018b6aac97d95ff5db8d4bd16addb9b Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b Build-ID 20141127001201 Version 34.0
You need to log in before you can comment on or make changes to this bug.