Closed Bug 1038221 Opened 5 years ago Closed 5 years ago

Fix some WMF destructors to be private

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → ehsan
Blocks: winclang
Attachment #8455399 - Flags: review?(bjacob)
Attachment #8455399 - Attachment is obsolete: true
Attachment #8455399 - Flags: review?(bjacob)
Attachment #8455626 - Flags: review?(cpearce)
Comment on attachment 8455626 [details] [diff] [review]
Fix some WMF destructors to be private

Review of attachment 8455626 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/wmf/WMFByteStream.cpp
@@ +395,5 @@
>  STDMETHODIMP
>  WMFByteStream::Read(BYTE* aBuffer, ULONG aBufferLength, ULONG* aOutBytesRead)
>  {
>    ReentrantMonitorAutoEnter mon(mReentrantMonitor);
> +  RefPtr<ReadRequest> request = new ReadRequest(mOffset, aBuffer, aBufferLength);

The mob has spoken. Use nsRefPtr going forward.
Attachment #8455626 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/800fbf0e4630
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.