Closed Bug 1038316 Opened 6 years ago Closed 6 years ago

ubi::Node should support ES6 Symbols

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jimb, Assigned: jimb)

References

Details

Attachments

(1 file)

ubi::Node should be able to refer to JS::Symbols, instead of crashing when it reaches one.
Attachment #8455510 - Flags: review?(jorendorff)
Attachment #8455510 - Flags: review?(jorendorff) → review?(sphink)
Comment on attachment 8455510 [details] [diff] [review]
Add support for ES6 Symbols to ubi::Node.

Review of attachment 8455510 [details] [diff] [review]:
-----------------------------------------------------------------

Seems straightforward enough.

::: js/src/builtin/TestingFunctions.cpp
@@ +1852,3 @@
>      //
> +    // or, if the node is some internal thing, that isn't a proper JavaScript
> +    // value:

Restrictive clause, so no comma before 'that'.

Do I get an award for "most pedantic review comment"?
Attachment #8455510 - Flags: review?(sphink) → review+
Thanks for the review!

I've been trying to attend to "that" vs. "which" and related issues; I think it's just getting me confused. I've fixed the restrictive clause.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=56871538498e
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f3a69331538
Assignee: nobody → jimb
Flags: in-testsuite+
Target Milestone: --- → mozilla34
https://hg.mozilla.org/mozilla-central/rev/7f3a69331538
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.