1038325 - [B2G][Email]Reply button icon is not displayed.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: 2014-07-14-13-47-35.png

When viewing a recieved email, the reply button on the bottom right corner of the screen does not display an icon. The button is still functional, just not displayed.

Repro Steps:
1) Update a Flame to BuildID: 20140714040201
2) Launch email app and sign into a profile
3) Tap on a received email
4) Observe reply button in bottom right corner

Actual:
A blank space is displayed where the reply icon should be.

Expected:
The reply icon is visibly displayed.

Master M/C Environmental Variables:
Device: Flame Master M/C
BuildID: 20140714040201
Gaia: 88e0a972280bb35847c010b8c3f1481fa80f3847
Gecko: f7aef4fc9d47
Version: 33.0a1
Firmware Version: v122

Notes:

Repro frequency: 100%
See attached: screenshot

Comment 1

[Ross Kuhlman ([e-mail])]

Reply button is properly displayed in v2.0.

Device: Flame v2.0
BuildID: 20140714000202
Gaia: ca022f811bcbbda0f89086094a9e92bb220fea18
Gecko: 376889ab0e02
Version: 32.0a2
Firmware Version: v122

Comment 2

[Peter Bylenga [:PBylenga]]

Nominating to block 2.0, is a regression that is highly visible and users will encounter it often.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Peter Bylenga [:PBylenga] from comment #2)
> Nominating to block 2.0, is a regression that is highly visible and users
> will encounter it often.

Comment 1 indicates this is not a problem on v2.0, just v2.1.  Clearing 2.0 blocking request.

Comment 4

[Peter Bylenga [:PBylenga]]

Sorry about that, should have been nominating to block 2.1.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

This is an accidental regression from bug 921050.  A random typo got into a selector making it no longer match.  I did notice this during a sanity check skim pass but assumed it was a specificity hack since we're constantly adding those.  In retrospect, "pp" was a pretty unlikely tag name.  Fix up momentarily.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Attachment: remove random typo from selector

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8456220 [details] [review]
remove random typo from selector

LGTM

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/21772
https://github.com/mozilla-b2g/gaia/commit/4036e085be26a51b39f5bbe062ea213b4c6f34a6

Comment 9

[Roland Kunkel [:RolandK]]

Verified as fixed for the latest 2.1 Flame build:

Environmental Variables:
----------------------------------------
Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Reply button icon is displayed and user can reply to emails as expected.