1038326 - [B2G][Search]'Added to Homescreen' message is cutoff after long pressing an E.me app and selecting 'Add to Homescreen'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: Add_to.png

Description:
Long pressing an E.me app then adding to homescreen will cut off the popup message 'Added to Homescreen'

Repro Steps:
1) Update a Flame to 20140714040201
2) Select the E.me search
3) Select share, type social and select 'Ok'
4) Long press on an app e.g. Facebook, Twitter.
5) Select 'Add to Homescreen'

Actual:
'Added to Homescreen' message is cutoff 

Expected:
'Added to Homescreen' message is not cutoff 

Environmental Variables:
Device: Flame Master
Build ID: 20140714040201
Gaia: 88e0a972280bb35847c010b8c3f1481fa80f3847
Gecko: f7aef4fc9d47
Version: 33.0a1 (Master)
Firmware Version: v122

User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Notes:
Repro frequency: 100%
See attached: screenshot

Comment 1

[Josh Schmitt [Joshs]]

Issue does not repro on 2.0 Flame

Environmental Variables:
Device: Flame 2.0
Build ID: 20140714000202
Gaia: ca022f811bcbbda0f89086094a9e92bb220fea18
Gecko: 376889ab0e02
Version: 32.0a2 (2.0)
Firmware Version: v122

User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Josh Schmitt [Joshs]]

Attachment: log.txt

Comment 3

[Peter Bylenga [:PBylenga]]

Nominating to block 2.0, is a regression and prevents user from being able to read the text of the notification.  Also requesting a regression window.

Comment 4

[Peter Bylenga [:PBylenga]]

Sorry, nominating to block 2.1 NOT 2.0.

Comment 5

[Amir Nissim (:amirn)]

Only happens when bookmarking from the Search app. Collection apps does not reproduce.

Dale, can you please give this a quick look?

Comment 6

[Dale Harvey (:daleharvey)]

I can, I think this is a regression caused by https://github.com/mozilla-b2g/gaia/commit/0b9620fbaed72b9cfd8d2557a1a8b6c3d59ca015

Comment 7

[Amir Nissim (:amirn)]

+Kevin

Comment 8

[Dale Harvey (:daleharvey)]

Sorry forgot to assign myself, almost have a patch for this, also filed https://bugzilla.mozilla.org/show_bug.cgi?id=1038702 which is related, https://github.com/mozilla-b2g/gaia/commit/88a22c3eafe5824e4b70f2ff639673a7534fcb4d was the actual regression

Comment 9

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21808

The 'rocketbar-results' CSS was unneeded and caused confusion as it was assumed it would apply to the search frame and not its children, rest of the fixes was just missed when switching from windows.css to windows_layout.css

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8456767 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21808

\O/

Comment 12

[Joshua Mitchell (Inactive)]

There is already an approved fix in for this, seems safe to remove the regression-window tag as that won't help much now; please re-add it if I'm wrong

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To whoever verifies this bug.  Please make sure that the red status bar no longer shows as well.  Otherwise, please reopen bug 1030259 as it was not fixed.

Comment 14

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/286b14d86798ed34f915406f2727109f809890e1

Comment 15

[Gregor Wagner [:gwagner]]

Already in 2.1