Make Your Own Make-Masonry

RESOLVED FIXED

Status

Webmaker
Teaching Kits / Curriculum
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: akirose, Assigned: akirose)

Tracking

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The makes on /make-your-own would be better displayed if masonry was rendering them as 300px bricks. I don't think we've pulled masonry into the angular app yet. Idk if that's a thing or not.
(Assignee)

Updated

4 years ago
See Also: → bug 1038389

Updated

3 years ago
Whiteboard: [techdebt] → [tech-debt]
(Assignee)

Comment 1

3 years ago
Created attachment 8479546 [details] [review]
https://github.com/mozilla/webmaker.org/pull/953

Looking for feedback, left a Q on the PR.
Assignee: nobody → aki
Status: NEW → ASSIGNED
Attachment #8479546 - Flags: feedback?(kate)
(Assignee)

Updated

3 years ago
Attachment #8479546 - Flags: feedback?(kate) → review?(kate)

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/4f489bf111c8d9b1078e3db837939c174fcb147d
Bug 1038390 - Make Your Own Make-Masonry

https://github.com/mozilla/webmaker.org/commit/a9f87bc4d26935c27cc9d59e216e5aba4256136e
Merge pull request #953 from gesa/1038390/masonry

Fixes Bug 1038390 - Make Your Own Make-Masonry & Fixes Bug 1059425 - "Make Your Own" makes should use new make directive

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Attachment #8479546 - Flags: review?(kate)
You need to log in before you can comment on or make changes to this bug.