Closed
Bug 1038406
Opened 10 years ago
Closed 10 years ago
static assertion failed: Reference-counted class ResourceSocketListener should not have a public destructor.
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jld, Assigned: jld)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
The --enable-media-plugins build seems to be broken again: content/media/plugins/MediaResourceServer.cpp:361:64: error: static assertion failed: Reference-counted class ResourceSocketListener should not have a public destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it.
|
Assignee | |
Comment 1•10 years ago
|
||
Simple patch is simple. Trying: https://tbpl.mozilla.org/?tree=Try&rev=0fd938d0ee13
Attachment #8455676 -
Flags: review?(cpearce)
|
||
Updated•10 years ago
|
Attachment #8455676 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
C-N note: try run in comment #1, but ignore the Windows reds; --enable-media-plugins is NPOTB on non-Fennec. (But this should be fixed anyway, even though it's not breaking the build yet and the only reason I noticed it was confusion about how gecko "media plugins" are different from "gecko media plugins".)
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04651e89a0c4
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04651e89a0c4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•