static assertion failed: Reference-counted class ResourceSocketListener should not have a public destructor.

RESOLVED FIXED in mozilla33

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla33
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The --enable-media-plugins build seems to be broken again:

content/media/plugins/MediaResourceServer.cpp:361:64: error: static assertion failed: Reference-counted class ResourceSocketListener should not have a public destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it.
(Assignee)

Comment 1

4 years ago
Created attachment 8455676 [details] [diff] [review]
bug1038406-more-gmp-bustage-hg0.diff

Simple patch is simple.  Trying: https://tbpl.mozilla.org/?tree=Try&rev=0fd938d0ee13
Attachment #8455676 - Flags: review?(cpearce)
Attachment #8455676 - Flags: review?(cpearce) → review+
(Assignee)

Comment 2

4 years ago
C-N note: try run in comment #1, but ignore the Windows reds; --enable-media-plugins is NPOTB on non-Fennec.  (But this should be fixed anyway, even though it's not breaking the build yet and the only reason I noticed it was confusion about how gecko "media plugins" are different from "gecko media plugins".)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/04651e89a0c4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.