Closed Bug 1038411 Opened 6 years ago Closed 6 years ago

Give myDownloadObserver a private destructor

Categories

(Core :: Widget: Win32, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → ehsan
Blocks: winclang
Attachment #8455682 - Flags: review?(bjacob)
Attachment #8455682 - Flags: review?(bjacob) → review+
Just adding a dtor breaks b2g desktop builds on Windows because they don't have MOZ_PLACES defined.  I think we should hide this class there completely.
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #2)
> Just adding a dtor breaks b2g desktop builds on Windows because they don't
> have MOZ_PLACES defined.  I think we should hide this class there completely.

https://tbpl.mozilla.org/php/getParsedLog.php?id=43847535&tree=Mozilla-Inbound#error0
Attachment #8455682 - Attachment is obsolete: true
Attachment #8456428 - Flags: review?(mak77)
Comment on attachment 8456428 [details] [diff] [review]
Give myDownloadObserver a private destructor

Review of attachment 8456428 [details] [diff] [review]:
-----------------------------------------------------------------

I was not aware of this code. What a fancy class name! :)

Btw, I think this makes sense, since this class is only used in code that is already wrapped by MOZ_PLACES
Attachment #8456428 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/f22e1fd54e85
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.