bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Give myDownloadObserver a private destructor

RESOLVED FIXED in mozilla33

Status

()

Core
Widget: Win32
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8455682 [details] [diff] [review]
Give myDownloadObserver a private destructor
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 752004
(Assignee)

Updated

4 years ago
Attachment #8455682 - Flags: review?(bjacob)
Attachment #8455682 - Flags: review?(bjacob) → review+
(Assignee)

Comment 2

4 years ago
Just adding a dtor breaks b2g desktop builds on Windows because they don't have MOZ_PLACES defined.  I think we should hide this class there completely.
(Assignee)

Comment 3

4 years ago
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #2)
> Just adding a dtor breaks b2g desktop builds on Windows because they don't
> have MOZ_PLACES defined.  I think we should hide this class there completely.

https://tbpl.mozilla.org/php/getParsedLog.php?id=43847535&tree=Mozilla-Inbound#error0
(Assignee)

Updated

4 years ago
Attachment #8455682 - Attachment is obsolete: true
(Assignee)

Comment 4

4 years ago
Created attachment 8456428 [details] [diff] [review]
Give myDownloadObserver a private destructor
(Assignee)

Updated

4 years ago
Attachment #8456428 - Flags: review?(mak77)
Comment on attachment 8456428 [details] [diff] [review]
Give myDownloadObserver a private destructor

Review of attachment 8456428 [details] [diff] [review]:
-----------------------------------------------------------------

I was not aware of this code. What a fancy class name! :)

Btw, I think this makes sense, since this class is only used in code that is already wrapped by MOZ_PLACES
Attachment #8456428 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/f22e1fd54e85
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.