1038467 - Rename content/media/plugins to content/media/android

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

When upcoming EME support, we'll be adding a new thing called "Gecko Media Plugins", so it's confusing to have a content/media/plugins dir which is actually for android, and not for general purpose "plugins".

So we should rename content/media/plugins to content/media/android to reflect that it's for android media and not for general purpose plugins.

We also need to rename the configure flags.

Comment 1

[cajbir (:cajbir)]

It was for general purpose plugins (MPAPI) at the time hence the name. Now that it's Android only I think it's worth renaming.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Rename files

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Rename classes

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8457696 [details] [diff] [review]
Rename classes

Review of attachment 8457696 [details] [diff] [review]:
-----------------------------------------------------------------

r=cpearce with ac_param flag name changed.

::: configure.in
@@ +5249,4 @@
>  fi
>  
>  MOZ_ARG_ENABLE_BOOL(media-plugins,
>  [  --enable-media-plugins  Enable support for media plugins],

Please rename --enable-media-plugins to --enable-andoid-omx or somesuch too.

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb7dda331d99
https://hg.mozilla.org/integration/mozilla-inbound/rev/7387d9d2e3b1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb7dda331d99
https://hg.mozilla.org/mozilla-central/rev/7387d9d2e3b1