Rename content/media/plugins to content/media/android

RESOLVED FIXED in mozilla33

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpearce, Assigned: eflores)

Tracking

29 Branch
mozilla33
x86_64
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

When upcoming EME support, we'll be adding a new thing called "Gecko Media Plugins", so it's confusing to have a content/media/plugins dir which is actually for android, and not for general purpose "plugins".

So we should rename content/media/plugins to content/media/android to reflect that it's for android media and not for general purpose plugins.

We also need to rename the configure flags.
It was for general purpose plugins (MPAPI) at the time hence the name. Now that it's Android only I think it's worth renaming.
Attachment #8457695 - Flags: review?(cpearce) → review+
Comment on attachment 8457696 [details] [diff] [review]
Rename classes

Review of attachment 8457696 [details] [diff] [review]:
-----------------------------------------------------------------

r=cpearce with ac_param flag name changed.

::: configure.in
@@ +5249,4 @@
>  fi
>  
>  MOZ_ARG_ENABLE_BOOL(media-plugins,
>  [  --enable-media-plugins  Enable support for media plugins],

Please rename --enable-media-plugins to --enable-andoid-omx or somesuch too.
Attachment #8457696 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/eb7dda331d99
https://hg.mozilla.org/mozilla-central/rev/7387d9d2e3b1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.