Closed Bug 1038535 Opened 6 years ago Closed 6 years ago

Flatten away idl/include/src subdirectories under caps/

Categories

(Core :: Security: CAPS, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: poiru, Assigned: poiru)

Details

Attachments

(1 file)

This is similar to e.g. bug 1028559 and bug 946065.

bholley, would you be OK with this?
Flags: needinfo?(bobbyholley)
Please do! Just make sure that the patch shows up in hg as a rename rather than delete+create. :-)
Flags: needinfo?(bobbyholley)
Comment on attachment 8456310 [details] [diff] [review]
Flatten caps/{idl,include,src}/ directories

Review of attachment 8456310 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Let's get a build peer to look at it too. Feel free to delegate gps.
Attachment #8456310 - Flags: review?(gps)
Attachment #8456310 - Flags: review?(bobbyholley)
Attachment #8456310 - Flags: review+
Comment on attachment 8456310 [details] [diff] [review]
Flatten caps/{idl,include,src}/ directories

Review of attachment 8456310 [details] [diff] [review]:
-----------------------------------------------------------------

This patch makes me very happy.

We love patches that consolidate moz.build files (within reason). Having fewer moz.build files makes the build system do less work and thus makes builds faster.
Attachment #8456310 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d3418a46399

(In reply to Gregory Szorc [:gps] from comment #4)
> Comment on attachment 8456310 [details] [diff] [review]
> Flatten caps/{idl,include,src}/ directories
> 
> Review of attachment 8456310 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This patch makes me very happy.
> 
> We love patches that consolidate moz.build files (within reason). Having
> fewer moz.build files makes the build system do less work and thus makes
> builds faster.

Then you will be even happier to know about bug 1038537, bug 1038458, and several others ;)
https://hg.mozilla.org/mozilla-central/rev/2d3418a46399
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.