Closed
Bug 1038536
Opened 10 years ago
Closed 9 years ago
Flatten away public/src subdirectories under image/
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: poiru, Assigned: poiru)
Details
Attachments
(4 files)
15.42 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
3.70 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
1.24 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
1.83 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
This is similar to e.g. bug 1028559 and bug 946065. Seth, would you be OK with this?
Flags: needinfo?(seth)
Assignee | ||
Updated•10 years ago
|
Summary: Flatten away public/src subdirectories under caps/ → Flatten away public/src subdirectories under image/
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8461590 -
Flags: review?(seth)
Flags: needinfo?(seth)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8461591 -
Flags: review?(seth)
Comment 3•10 years ago
|
||
I'm deliberately holding off on r+'ing this until some existing bugs land, to avoid any rebasing issues.
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Seth Fowler [:seth] from comment #3) > I'm deliberately holding off on r+'ing this until some existing bugs land, > to avoid any rebasing issues. Have these bugs landed yet?
Status: NEW → ASSIGNED
Flags: needinfo?(seth)
Comment 5•10 years ago
|
||
No, unfortunately. imagelib is in a really heavy state of churn right now. But maybe that's actually an argument that we should go ahead and just land this; things probably won't get better for a couple of months at least.
Flags: needinfo?(seth)
Updated•10 years ago
|
Attachment #8461590 -
Flags: review?(seth) → review+
Updated•10 years ago
|
Attachment #8461591 -
Flags: review?(seth) → review+
Assignee | ||
Comment 7•9 years ago
|
||
I went ahead and landed the image/public/ bit. Let me know if/when I can land the image/src/ patch.
Keywords: leave-open
Comment 9•9 years ago
|
||
The header guard in ImageLogging.h is out of compliance with the Mozilla coding style due to its relocation. It should now be mozilla_image_ImageLogging_h instead of mozilla_image_public_ImageLogging_h I'll post a separate patch for image/src headers, to be applied after the image/src files are relocated.
Assignee: birunthan → glennrp+bmo
Attachment #8603117 -
Flags: review?(seth)
Updated•9 years ago
|
Assignee: glennrp+bmo → birunthan
Comment 10•9 years ago
|
||
Comment on attachment 8603117 [details] [diff] [review] v00-1038356-update-build-headers-after-flatten Review of attachment 8603117 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, Glenn!
Attachment #8603117 -
Flags: review?(seth) → review+
Updated•9 years ago
|
Attachment #8603117 -
Flags: checkin?
Comment 12•9 years ago
|
||
(In reply to Birunthan Mohanathas [:poiru] from comment #7) > I went ahead and landed the image/public/ bit. Let me know if/when I can > land the image/src/ patch. Now that we're past the Gecko 40 merge to Aurora, I think it's a good time. Go for it, whenever you're ready.
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #8605553 -
Flags: review?(seth)
Comment 15•9 years ago
|
||
Comment on attachment 8605553 [details] [diff] [review] Flatten image/decoders/icon/qt/public/ directory Review of attachment 8605553 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #8605553 -
Flags: review?(seth) → review+
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b122f0b6fcf https://hg.mozilla.org/integration/mozilla-inbound/rev/c4551f3019a9
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cafa8c19cc63 for mass bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=9831417&repo=mozilla-inbound
Flags: needinfo?(birunthan)
Updated•9 years ago
|
Attachment #8603117 -
Flags: checkin?
Comment 18•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0b9343094e0 https://hg.mozilla.org/integration/mozilla-inbound/rev/7701abd92485
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(birunthan)
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f0b9343094e0 https://hg.mozilla.org/mozilla-central/rev/7701abd92485
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•