Flatten away public/src subdirectories under image/

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: poiru, Assigned: poiru)

Tracking

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

5 years ago
This is similar to e.g. bug 1028559 and bug 946065.

Seth, would you be OK with this?
Flags: needinfo?(seth)
(Assignee)

Updated

5 years ago
Summary: Flatten away public/src subdirectories under caps/ → Flatten away public/src subdirectories under image/
(Assignee)

Comment 1

4 years ago
Created attachment 8461590 [details] [diff] [review]
Flatten image/src/ directory
Attachment #8461590 - Flags: review?(seth)
Flags: needinfo?(seth)
(Assignee)

Comment 2

4 years ago
Created attachment 8461591 [details] [diff] [review]
Flatten image/public/ directory
Attachment #8461591 - Flags: review?(seth)
I'm deliberately holding off on r+'ing this until some existing bugs land, to avoid any rebasing issues.
(Assignee)

Comment 4

4 years ago
(In reply to Seth Fowler [:seth] from comment #3)
> I'm deliberately holding off on r+'ing this until some existing bugs land,
> to avoid any rebasing issues.

Have these bugs landed yet?
Status: NEW → ASSIGNED
Flags: needinfo?(seth)
No, unfortunately. imagelib is in a really heavy state of churn right now. But maybe that's actually an argument that we should go ahead and just land this; things probably won't get better for a couple of months at least.
Flags: needinfo?(seth)
Attachment #8461590 - Flags: review?(seth) → review+
Attachment #8461591 - Flags: review?(seth) → review+
(Assignee)

Comment 7

4 years ago
I went ahead and landed the image/public/ bit. Let me know if/when I can land the image/src/ patch.
Keywords: leave-open
Created attachment 8603117 [details] [diff] [review]
v00-1038356-update-build-headers-after-flatten

The header guard in ImageLogging.h is out of compliance with the Mozilla coding style due to its relocation.  It should now be

mozilla_image_ImageLogging_h
instead of
mozilla_image_public_ImageLogging_h

I'll post a separate patch for image/src headers, to be applied after the image/src files are relocated.
Assignee: birunthan → glennrp+bmo
Attachment #8603117 - Flags: review?(seth)
Assignee: glennrp+bmo → birunthan
Comment on attachment 8603117 [details] [diff] [review]
v00-1038356-update-build-headers-after-flatten

Review of attachment 8603117 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Glenn!
Attachment #8603117 - Flags: review?(seth) → review+
Attachment #8603117 - Flags: checkin?
(In reply to Birunthan Mohanathas [:poiru] from comment #7)
> I went ahead and landed the image/public/ bit. Let me know if/when I can
> land the image/src/ patch.

Now that we're past the Gecko 40 merge to Aurora, I think it's a good time. Go for it, whenever you're ready.
(Assignee)

Comment 14

4 years ago
Created attachment 8605553 [details] [diff] [review]
Flatten image/decoders/icon/qt/public/ directory
Attachment #8605553 - Flags: review?(seth)
Comment on attachment 8605553 [details] [diff] [review]
Flatten image/decoders/icon/qt/public/ directory

Review of attachment 8605553 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8605553 - Flags: review?(seth) → review+
(Assignee)

Updated

4 years ago
Keywords: leave-open
Attachment #8603117 - Flags: checkin?
(Assignee)

Updated

4 years ago
Flags: needinfo?(birunthan)
https://hg.mozilla.org/mozilla-central/rev/f0b9343094e0
https://hg.mozilla.org/mozilla-central/rev/7701abd92485
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.