Bug 1038537

Flatten away idl/public/src subdirectories under intl/

RESOLVED FIXED in mozilla34

Get help with this page

Status

()

Product:

Component:

Type:

defect

Status:

RESOLVED FIXED

Opened:

5 years ago

Updated:

5 years ago

People

(Reporter: poiru, Assigned: poiru)

Tracking

Version:

Trunk

Target:

mozilla34

Points:

---

Blocks:

1044437

Dependency tree / graph

Duplicates:

979090

Bug Flags:

madamezou

qe-verify

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(9 attachments)

Flatten intl/chardet/{public,src}/ directories 5 years ago Birunthan Mohanathas [:poiru] 3.94 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/hyphenation/{public,src}/ directories 5 years ago Birunthan Mohanathas [:poiru] 5.26 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/locale/src/ directory 5 years ago Birunthan Mohanathas [:poiru] 11.67 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/locale/{public,idl}/ directories 5 years ago Birunthan Mohanathas [:poiru] 4.57 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/lwbrk/{idl,public,src}/ directories 5 years ago Birunthan Mohanathas [:poiru] 8.69 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/strres/{public,src}/ directories 5 years ago Birunthan Mohanathas [:poiru] 3.75 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/uconv/src/ directory 5 years ago Birunthan Mohanathas [:poiru] 21.06 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/uconv/{idl,public}/ directories 5 years ago Birunthan Mohanathas [:poiru] 4.34 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review
Flatten intl/unicharutil/{idl,public,src}/ directories 5 years ago Birunthan Mohanathas [:poiru] 7.04 KB, patch	smontagu : review+	Details \| Diff \| Splinter Review

Birunthan Mohanathas [:poiru]

Assignee

Description

•

5 years ago

This is similar to e.g. bug 1028559 and bug 946065.

Simon, would you be OK with this?

Flags: needinfo?(smontagu)

Simon Montagu :smontagu

Comment 1

•

5 years ago

Go for it

Flags: needinfo?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 2

•

5 years ago

Posted patch Flatten intl/chardet/{public,src}/ directories — Details — Splinter Review

Attachment #8456639 - Flags: review?(smontagu)

Attachment #8456640 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 3

•

5 years ago

Posted patch Flatten intl/hyphenation/{public,src}/ directories — Details — Splinter Review

Birunthan Mohanathas [:poiru]

Assignee

Comment 4

•

5 years ago

Posted patch Flatten intl/locale/src/ directory — Details — Splinter Review

Attachment #8456641 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 5

•

5 years ago

Posted patch Flatten intl/locale/{public,idl}/ directories — Details — Splinter Review

Attachment #8456642 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 6

•

5 years ago

Posted patch Flatten intl/lwbrk/{idl,public,src}/ directories — Details — Splinter Review

Attachment #8456643 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 7

•

5 years ago

Posted patch Flatten intl/strres/{public,src}/ directories — Details — Splinter Review

Attachment #8456644 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 8

•

5 years ago

Posted patch Flatten intl/uconv/src/ directory — Details — Splinter Review

Attachment #8456645 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 9

•

5 years ago

Posted patch Flatten intl/uconv/{idl,public}/ directories — Details — Splinter Review

Attachment #8456646 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 10

•

5 years ago

Posted patch Flatten intl/unicharutil/{idl,public,src}/ directories — Details — Splinter Review

Attachment #8456647 - Flags: review?(smontagu)

Birunthan Mohanathas [:poiru]

Assignee

Comment 11

•

5 years ago

Try push: https://tbpl.mozilla.org/?tree=Try&rev=84fc6f1ad59a

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456639 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456640 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456641 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456642 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456643 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456644 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Blocks: 979090

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456645 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456646 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Updated

•

5 years ago

Attachment #8456647 - Flags: review?(smontagu) → review+

Simon Montagu :smontagu

Comment 12

•

5 years ago

Does this need build peer review?

Flags: needinfo?(gps)

Gregory Szorc [:gps]

Comment 13

•

5 years ago

I glanced at half the patches and the changes look like a simple refactoring. Since you are only touching things in moz.build, I'm confident that the build system or automation would catch any problems with the conversion.

Flags: needinfo?(gps)

Gregory Szorc [:gps]

Comment 14

•

5 years ago

I should have said "land this."

Birunthan Mohanathas [:poiru]

Assignee

Comment 15

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bda1cceef8d2
https://hg.mozilla.org/integration/mozilla-inbound/rev/9230143db3b7
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79894a533bc
https://hg.mozilla.org/integration/mozilla-inbound/rev/0732215ac8e8
https://hg.mozilla.org/integration/mozilla-inbound/rev/345f6e3e6972
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7d58108070
https://hg.mozilla.org/integration/mozilla-inbound/rev/4feaed7d41de
https://hg.mozilla.org/integration/mozilla-inbound/rev/38b4378f21c0
https://hg.mozilla.org/integration/mozilla-inbound/rev/80aec550b1e0

Try push: https://tbpl.mozilla.org/?tree=Try&rev=84fc6f1ad59a

Status: NEW → ASSIGNED

Birunthan Mohanathas [:poiru]

Assignee

Updated

•

5 years ago

Duplicate of this bug: 979090

Wes Kocher (:KWierso)

Comment 17

•

5 years ago

https://hg.mozilla.org/mozilla-central/rev/bda1cceef8d2
https://hg.mozilla.org/mozilla-central/rev/9230143db3b7
https://hg.mozilla.org/mozilla-central/rev/b79894a533bc
https://hg.mozilla.org/mozilla-central/rev/0732215ac8e8
https://hg.mozilla.org/mozilla-central/rev/345f6e3e6972
https://hg.mozilla.org/mozilla-central/rev/0d7d58108070
https://hg.mozilla.org/mozilla-central/rev/4feaed7d41de
https://hg.mozilla.org/mozilla-central/rev/38b4378f21c0
https://hg.mozilla.org/mozilla-central/rev/80aec550b1e0

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

Resolution: --- → FIXED

Target Milestone: --- → mozilla34

Philip Chee

Updated

•

5 years ago

No longer blocks: 979090

Ian Neal

Updated

•

5 years ago

Blocks: 1044437

Francesca Ciceri [:madamezou]

Updated

•

5 years ago

Flags: qe-verify-

You need to log in before you can comment on or make changes to this bug.