Closed
Bug 1038544
Opened 10 years ago
Closed 10 years ago
ubi::Node should provide a 'zone' member function
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jimb, Assigned: jimb)
References
Details
Attachments
(1 file, 3 obsolete files)
7.13 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Here's a patch. Not yet requesting review; needs tests and a Try push.
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b1de14a17eae
Assignee: nobody → jimb
Attachment #8455937 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8462954 -
Flags: review?(sphink)
Assignee | ||
Updated•10 years ago
|
Attachment #8462954 -
Flags: review?(sphink) → review?(terrence)
Comment 2•10 years ago
|
||
How about a /green/ Try run first, too? ;-)
Assignee | ||
Comment 3•10 years ago
|
||
I hear it helps when you actually include your test file in the patch... *sigh* https://tbpl.mozilla.org/?tree=Try&rev=f16138d81897
Attachment #8462954 -
Attachment is obsolete: true
Attachment #8462954 -
Flags: review?(terrence)
Attachment #8465108 -
Flags: review?(terrence)
Assignee | ||
Comment 4•10 years ago
|
||
Forgot to qrefresh before pushing to try. I blame MQ. https://tbpl.mozilla.org/?tree=Try&rev=06b20890ab92
Attachment #8465108 -
Attachment is obsolete: true
Attachment #8465108 -
Flags: review?(terrence)
Attachment #8465537 -
Flags: review?(terrence)
Comment 5•10 years ago
|
||
Comment on attachment 8465108 [details] [diff] [review] Implement ubi::Node::zone, to return the JS::Zone to which the node's referent belongs. Review of attachment 8465108 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi-tests/testUbiNode.cpp @@ +5,5 @@ > +#include "js/UbiNode.h" > + > +#include "jsapi-tests/tests.h" > + > +using namespace JS; Please remove this. The jsapi-tests are also unified, and we have had bustage several times now from accidental bootlegging of JS::.
Attachment #8465108 -
Attachment is obsolete: false
Updated•10 years ago
|
Attachment #8465537 -
Flags: review?(terrence) → review+
Updated•10 years ago
|
Attachment #8465108 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/61a25c10da62
Flags: in-testsuite-
Target Milestone: --- → mozilla34
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #5) > > +using namespace JS; > > Please remove this. The jsapi-tests are also unified, and we have had > bustage several times now from accidental bootlegging of JS::. Removed; thanks for calling that out.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a379f2213495 for build failures: https://tbpl.mozilla.org/php/getParsedLog.php?id=45000614&tree=Mozilla-Inbound
Flags: needinfo?(jimb)
Assignee | ||
Comment 9•10 years ago
|
||
Re-landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/d908d662d015
Flags: needinfo?(jimb)
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d908d662d015
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•