Closed
Bug 1038588
Opened 10 years ago
Closed 10 years ago
DebuggerServer's closeListener has been changed to closeAllListeners()
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird33 fixed, thunderbird34 fixed)
RESOLVED
FIXED
Thunderbird 34.0
People
(Reporter: ewong, Assigned: ewong)
Details
Attachments
(1 file)
939 bytes,
patch
|
Fallen
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8456017 -
Flags: review?(mconley) → review?(philipp)
Comment 2•10 years ago
|
||
Comment on attachment 8456017 [details] [diff] [review] patch Review of attachment 8456017 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch, r=philipp When was this changed? A recent nightly?
Attachment #8456017 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Philipp Kewisch [:Fallen] from comment #2) > Comment on attachment 8456017 [details] [diff] [review] > patch > > Review of attachment 8456017 [details] [diff] [review]: > ----------------------------------------------------------------- > > Thanks for the patch, r=philipp > > When was this changed? A recent nightly? Basically a change in the API from http://hg.mozilla.org/mozilla-central/rev/9c484bb185fd
Comment 4•10 years ago
|
||
Just copying the reported error here to make this bug show up in bug search: Error: Unable to stop debugger server: TypeError: DebuggerServer.closeListener is not a function Source File: resource://gre/modules/RemoteDebuggerServer.jsm Line: 186
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8456017 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: DebuggerServer erroring with "Unable to stop debugger server: TypeError: DebuggerServer.closeListener is not a function" Testing completed (on c-c, etc.): Risk to taking this patch (and alternatives if risky): None
Attachment #8456017 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 6•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/acb745a4d796
Updated•10 years ago
|
Attachment #8456017 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/4be3eacc5ee0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-thunderbird33:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
Updated•10 years ago
|
status-thunderbird34:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•