Closed Bug 1038588 Opened 10 years ago Closed 10 years ago

DebuggerServer's closeListener has been changed to closeAllListeners()

Categories

(Thunderbird :: General, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(thunderbird33 fixed, thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird33 --- fixed
thunderbird34 --- fixed

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8456017 - Flags: review?(mconley)
Attachment #8456017 - Flags: review?(mconley) → review?(philipp)
Comment on attachment 8456017 [details] [diff] [review]
patch

Review of attachment 8456017 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, r=philipp

When was this changed? A recent nightly?
Attachment #8456017 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 8456017 [details] [diff] [review]
> patch
> 
> Review of attachment 8456017 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for the patch, r=philipp
> 
> When was this changed? A recent nightly?

Basically a change in the API from
http://hg.mozilla.org/mozilla-central/rev/9c484bb185fd
Just copying the reported error here to make this bug show up in bug search:

Error: Unable to stop debugger server: TypeError: DebuggerServer.closeListener is not a function
Source File: resource://gre/modules/RemoteDebuggerServer.jsm
Line: 186
Comment on attachment 8456017 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: DebuggerServer erroring with "Unable to stop debugger server: TypeError: DebuggerServer.closeListener is not a function"
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): None
Attachment #8456017 - Flags: approval-comm-aurora?
Attachment #8456017 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/4be3eacc5ee0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.