[FIX] dialshr.cpp calling getPhoneBookNT() on non-NT machines

VERIFIED INVALID

Status

CCK
CCK-General
P3
normal
VERIFIED INVALID
19 years ago
17 years ago

People

(Reporter: Jordan Mendelson, Assigned: selmer (gone))

Tracking

Details

(Reporter)

Description

19 years ago
Right around line 2332, in cck/muc/dialshr.cpp you have this block of code:

	// Creating connection entry!
   	char*		pbPath = NULL;

	if ( gPlatformOS = VER_PLATFORM_WIN32_NT )
		pbPath = getPhoneBookNT();
	else
		pbPath = (char*)account.ISPName;

Line 2332 itself should read:

	if ( gPlatformOS == VER_PLATFORM_WIN32_NT )

if I'm not mistaken (== not =).
(Reporter)

Comment 1

19 years ago
Same thing on line 2362, this code will always execute:

	ret = ( dwRet == 0 );

	if ( gPlatformOS = VER_PLATFORM_WIN32_NT )
	{
		RASCREDENTIALS credentials;

		// sets up user login info for new phonebook entry

Line 2362:

	if ( gPlatformOS = VER_PLATFORM_WIN32_NT )

Should read

	if ( gPlatformOS == VER_PLATFORM_WIN32_NT )
(Reporter)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → INVALID
(Reporter)

Comment 2

19 years ago
Woops, didn't realize there was more than one version of dialshr.cpp in the
tree.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 3

19 years ago
Marking Verified/Invalid

Comment 4

17 years ago
->CCK-General. Other CCK Components going away.
Component: Dialup-Mup/Muc → CCK-General
You need to log in before you can comment on or make changes to this bug.