Closed Bug 1038651 Opened 5 years ago Closed 5 years ago

Inspector breaks when reloading on SVG file

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 33

People

(Reporter: bgrins, Assigned: bgrins)

References

()

Details

Attachments

(1 file)

Open: http://www.w3.org/TR/SVG/images/paths/triangle01.svg
Reload the page

Error: undefined passed where a value is required
Stack trace:
identityWrite@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:112:1
Arg<.write@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:411:12
Request<.write/str<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:582:1
Request<.write@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:580:15
frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1202:20
exports.WalkerFront<.querySelector<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:2313:12
InspectorPanel.prototype._getDefaultNodeForSelection/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:222:14
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:866:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:745:7
Blocks: 1020984
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attached patch svg-reload.patchSplinter Review
Fixes issue with reloading on SVG file, adds test
Attachment #8456330 - Flags: review?(mratcliffe)
Comment on attachment 8456330 [details] [diff] [review]
svg-reload.patch

Review of attachment 8456330 [details] [diff] [review]:
-----------------------------------------------------------------

Because getAdjustedQuads returns null if !node || !node.getBoxQuads this seems like a great solution, r+.
Attachment #8456330 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/869f9ac3e3ba
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
QA Whiteboard: [good first verify]
Verified as fixed on Nightly 34.0a1 (2014-08-28)
Reloading http://www.w3.org/TR/SVG/images/paths/triangle01.svg does not trigger any errors
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.