Closed Bug 1038675 Opened 6 years ago Closed 6 years ago
At parameter of /call-url/ response has changed from hours to seconds (Loop desktop client doesn't register on startup of browser)
The current production server is returning hours for the "expiresAt" parameter, whereas the latest version on master is now returning seconds. This is causing a regression in the client for it to not register on startup. This is because we take the expiresAt and multiply it up into seconds, but it gets truncated at 32 bits. AFAIK this wasn't a planned change.
A solution to this should block a 0.9.0 server release, as otherwise people might not receive incoming calls as their client doesn't think it is necessary to register.
I think it was a mistake to have it in hours. Unix timestamp are a standard and we tried to make sure all expiration date where timestamp for MVP.
We're going to fix this on the client, and it'll be likely it might break things on nightly for a few days until the server is fixed up, but for most people that shouldn't be too bad.
Assignee: nobody → standard8
Component: Server → Client
Attachment #8456729 - Flags: review?(nperriault)
Comment on attachment 8456729 [details] [diff] [review] expiresAt parameter of /call-url/ response has changed from hours to seconds with the latest server version (Loop desktop client doesn't register on startup of browser). Review of attachment 8456729 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8456729 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/79a9cefa3538 Will post to dev-media before the nightlies are released.
Priority: -- → P1
Target Milestone: --- → mozilla33
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Mark, can you please confirm if this needs manual testing?
Whiteboard: [p=1] [qa?] → [p=1]
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #8) > Mark, can you please confirm if this needs manual testing? I don't think we need extra manual testing for this. This is generally tested with the panel tests.
You need to log in before you can comment on or make changes to this bug.