Closed Bug 1038698 Opened 10 years ago Closed 10 years ago

Intermittent test_a11y_utility_tray_visibility.py TestUtilityTrayVisibilityAccessibility.test_a11y_utility_tray_visibility | AssertionError: False is not true

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cbook, Assigned: yzen)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Github pull request.
46 bytes, text/x-github-pull-request
jgriffin
: review+
zcampbell
: feedback+
Details | Review 
b2g_macosx64 b2g-inbound opt test gaia-ui-test on 2014-07-15 05:51:41 PDT for push f927b28f8e5b

slave: talos-mtnlion-r5-031

https://tbpl.mozilla.org/php/getParsedLog.php?id=43823004&tree=B2g-Inbound



TEST-UNEXPECTED-FAIL | test_a11y_utility_tray_visibility.py TestUtilityTrayVisibilityAccessibility.test_a11y_utility_tray_visibility | AssertionError: False is not true
I think we'll have to disable this test, it seems very fragile today.
ni? yzen because of the importance.
Flags: needinfo?(yzenevich)
This is not an intermittent: a regression is caused by bug 1038185 and this commit https://github.com/mozilla-b2g/gaia/commit/8e90912c8d3edacd56fb0eb68b9cee0792a75785
Flags: needinfo?(yzenevich)
(In reply to Yura Zenevich [:yzen] from comment #34)
> This is not an intermittent: a regression is caused by bug 1038185 and this
> commit
> https://github.com/mozilla-b2g/gaia/commit/
> 8e90912c8d3edacd56fb0eb68b9cee0792a75785

Great! You know what to do!  (also, back out my commit that disabled the test)
Re-enabled the tests after reverting the regression: https://github.com/mozilla-b2g/gaia/commit/b3cf3755539cac6006415de4743d0990c9e4e3d4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
So I notice the test doesn't actually seem to wait for the utility tray to close after it closes it...(?) I'll investigate on the reopened bug.
(In reply to Chris Lord [:cwiiis] from comment #38)
> So I notice the test doesn't actually seem to wait for the utility tray to
> close after it closes it...(?) I'll investigate on the reopened bug.

Yeah, I would think that with the fix for the original bug the test needs to be updated to account for that.
this is back and permaorange on b2g-inbound - maybe it needs to be disabled again ?
Flags: needinfo?(zach)
Flags: needinfo?(yzenevich)
Will provide a fix shortly.
Status: RESOLVED → REOPENED
Flags: needinfo?(yzenevich)
Resolution: FIXED → ---
Assignee: nobody → yzenevich
Attached file Github pull request. — 

        Attachment #8481465 -
        Flags: review?(zcampbell)

    
    

    
  
Comment on attachment 8481465 [details] [review]
Github pull request.

I don't have time to run it today so I can give it f+ now.

        Attachment #8481465 -
        Flags: review?(zcampbell) → feedback+

        Attachment #8481465 -
        Flags: review?(jgriffin)

    
    

    
      
  

    
    

    
  
Comment on attachment 8481465 [details] [review]
Github pull request.

The patch looks totally reasonable, and it works ok on try.  I think the concern is that it might break something in the on-device automation, which I'm not in a position to test.  So, I'll give this an r+, but with the caveat that you might want to wait until Zac has a chance to confirm it doesn't break on-device tests, unless this is urgent enough to trump that risk.

        Attachment #8481465 -
        Flags: review?(jgriffin) → review+

    
    

    
  
Zac, what's your take on comment 77? This is a contributing factor to Gaia being closed on the weekend before FL.
Flags: needinfo?(zach) → needinfo?(zcampbell)

    
    

    
  
I will give it an r? today and let y'all know.

    
    

    
  
There are no negative effects when running this on device.
Flags: needinfo?(zcampbell)

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/8029a2a7a439253534cc327816ed034f0d4c30d4
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Keywords: intermittent-failure
Resolution: --- → FIXED

    
    

    
  
Why was that merged with failures on try that were not even retriggered?

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: