Closed Bug 1038774 Opened 9 years ago Closed 9 years ago

products set to be hidden from dashboard aren't hidden

Categories

(Input Graveyard :: Dashboard, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=user c=dashboard p=2 s=input.2014q3)

There's a field in the product table that allows us to specify that a product should be hidden from public view. This appears not to be doing anything.

If a product is marked as "hidden", it should be hidden from the following:

1. the public dashboard
2. response view
3. Input GET API
https://github.com/mozilla/fjord/commit/672abba fixes items 1 and 2.

I have to mull over how to fix 3 well. Seems like the API should raise an error if someone asks for a product that doesn't exist, but there's not error mechanism in place right now.

I need to test this a bit more on stage and then I'll push to prod.
Assignee: nobody → willkg
Making this a P1. It should have been implemented this way before. This is important so we can support some products.
Priority: -- → P1
Fixed items 1 and 2 in master:

https://github.com/mozilla/fjord/commit/672abba

Just pushed it to production.

I'm tossing around whether to fix item 3 or not. I think I'm going to defer it for now. Thus marking this as FIXED.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.