1038815 - Contacts can get into a 'frozen' state in some cases

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

In some cases, for example by pressing the settings button repeatedly, Contacts will go into a blank screen, with the user having to restart the app.

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

This patch ensures that Contacts will come back to a valid state even if it freezes up. The patch doesn't do much, mostly because the architecture for subsections will change soon and the code in navigation.js will become obsolete.

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8456287 [details]
Github PR

https://github.com/mozilla-b2g/gaia/pull/21831/files

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Actual Github PR

Actual pull request

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8457051 [details] [diff] [review]
Actual Github PR

Can we create unit tests for this?

I know sometimes we will endup writing more tests than patches, but sure will be helpful in time.

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Of course, no problem.

Comment 7

[Jason Smith [:jsmith]]

Carrying over flags from the dupe.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8457051 [details] [diff] [review]
Actual Github PR

We have been speaking offline to land this, since the change is pretty simple and do a follow up with integration tests (we'll need a bit of time to do this tests)

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

We have created bug 1056081 to add integration tests to this use case.

Comment 10

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged at 4ccb207518f62baa5160a735a6189d3ba9d34e1d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a36a504f35bd9d1c20726624abe6433ce5dbfb54