1038837 - Factor out mozilla::pkix::der::Input into its own header and move it out of the "der::" namespace

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: factor-out-Input-Result-etc.patch

I want to be able to pass Input objects to the TrustDomain callbscks instead of passing them less-safe-to-use SECItems. This patch is the first step towards acheiving that. The overall goals are to make TrustDomain implementations safer, and to reduce the use of SECItem (which will happen in future patches).

I'd like to land this before the merge to Aurora so that it will be easier to uplift patches from Nightly 34 to Aurora 33.

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8456306 [details] [diff] [review]
factor-out-Input-Result-etc.patch

Review of attachment 8456306 [details] [diff] [review]:
-----------------------------------------------------------------

LG pending green try.

::: security/pkix/include/pkix/Result.h
@@ +80,5 @@
> +Fail(PRErrorCode errorCode)
> +{
> +  PR_ASSERT(errorCode != 0);
> +  PR_SetError(errorCode, 0);
> +  return MapSECStatus(SECFailure);

Hmm, 2 MapSECStatuses...

Can this be mozilla::pkix::MapSECStatus for clarity?

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8456306 [details] [diff] [review]
factor-out-Input-Result-etc.patch

Review of attachment 8456306 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/58fe2785ca6a

::: security/pkix/include/pkix/Result.h
@@ +80,5 @@
> +Fail(PRErrorCode errorCode)
> +{
> +  PR_ASSERT(errorCode != 0);
> +  PR_SetError(errorCode, 0);
> +  return MapSECStatus(SECFailure);

I guess you are referring to the other MapSECStatus in ScopedNSSTypes ( nsresult MapSECStatus(SECStatus)), right? OK, I added the qualifier. Though, in my next patchset I remove this code completely.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58fe2785ca6a