1038841 - navigational buttons are cut off during account creation

Status: RESOLVED DUPLICATE of bug 1047411

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Tiffanie Shakespeare [:tif]]

Attachment: buttons cut off

Pre-condition: not be signed in

STR:
1. Go into Settings-> Find my device
2. Tap button to create an account
3. Enter email address and dismiss keyboard

Expected
Navigational buttons are whole and easily read

Actual
All navigational buttons through the rest of the process are cut in half.

Comment 1

[Tiffanie Shakespeare [:tif]]

On the Flame

Gaia      d1e91fcde914e8ff228b48bdd95139c4a508ecc0
Gecko     https://hg.mozilla.org/mozilla-central/rev/f7aef4fc9d47
BuildID   20140714040201
Version   33.0a1

Comment 2

[Russ Nicoletti [:russn]]

I am looking into this.

Comment 3

[Kate Glazko]

I have seen this on 2.1.0. today, the buttons are clearly truncated.

Comment 4

[Russ Nicoletti [:russn]]

I've determined the build that first resulted in this behavior:

Gaia       40cac290f0a3253d31242d7f50b1d2ddd2f47cda
Gecko      https://hg.mozilla.org/mozilla-central/rev/84bd8d9f4256
BuildID    20140711160203

This build does not reproduce:

Gaia      c47094a26c87ba71a3da4bae54febd0da21f3393
Gecko     https://hg.mozilla.org/mozilla-central/rev/1b1296d00330
BuildID   2014071104020

Comment 5

[Russ Nicoletti [:russn]]

Drilling down, I've found the gaia commit where the issue first reproduces:

aa854630f141e8d6f5bfb47d27cb7da7cb1681aa

The issue does not reproduce with the commit just prior to the above commit:

f36a8a38808a50cae8455ba8eda76ec3eccb34c8

However, only one file was changed by aa854630f1 (apps/system/js/notifications.js) and it is not related to this issue.

Comment 6

[Russ Nicoletti [:russn]]

The commit that introduced the change that results in this issue is:

https://github.com/mozilla-b2g/gaia/commit/88a22c3eafe5824e4b70f2ff639673a7534fcb4d

The line of code that was changed is:

https://github.com/mozilla-b2g/gaia/blob/88a22c3eafe5824e4b70f2ff639673a7534fcb4d/apps/system/js/layout_manager.js#L58

After the change, AttentionScreen.statusHeight returns zero. Whereas, before the change,  StatusBar.height returns 24. 

The result is, LayoutManager.height is 480 after the change, and 456 before the change.

It seems LayoutManager.height may need to determine when to use AttentionScreen.statusHeight vs. when to use StatusBar.height. 

In any event, NI for Vivien to comment. I'm especially interested in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1033364#c4

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Seems a duplicated of bug 1047411 and the various other duplicates that have appears. I fixed those issues in bug 1047411, and I just try this particular use case and it works well on my device.