1038855 - SharedMemoryBasic fields should use nsRefPtr

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

SharedMemoryBasic inherits from SharedMemory, which is a refcounted class.  CrossProcessMutex, CompositorChild::SharedFrameMetricsData and AsyncPanZoomController fail to do this.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use an nsRefPtr for AsyncPanZoomController::mSharedFrameMetricsBuffer.

This is all straightforward.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Use an nsRefPtr for CompositorChild::SharedFrameMetricsData::mBuffer.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Use an nsRefPtr for CrossProcessMutex::mSharedBuffer.

Comment 4

[Andrew McCreight [:mccr8]]

hmm I'll ditch the |mBuffer = nullptr;| in the second patch...

Comment 5

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f60bdae3c097
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf6c098623d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/74034d6b6ae6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f60bdae3c097
https://hg.mozilla.org/mozilla-central/rev/2bf6c098623d
https://hg.mozilla.org/mozilla-central/rev/74034d6b6ae6