SharedMemoryBasic fields should use nsRefPtr

RESOLVED FIXED in mozilla33

Status

()

Core
IPC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
SharedMemoryBasic inherits from SharedMemory, which is a refcounted class.  CrossProcessMutex, CompositorChild::SharedFrameMetricsData and AsyncPanZoomController fail to do this.
(Assignee)

Comment 1

4 years ago
Created attachment 8456521 [details] [diff] [review]
part 1 - Use an nsRefPtr for AsyncPanZoomController::mSharedFrameMetricsBuffer.

This is all straightforward.
Attachment #8456521 - Flags: review?(bjacob)
(Assignee)

Comment 2

4 years ago
Created attachment 8456522 [details] [diff] [review]
part 2 - Use an nsRefPtr for CompositorChild::SharedFrameMetricsData::mBuffer.
Attachment #8456522 - Flags: review?(bjacob)
(Assignee)

Comment 3

4 years ago
Created attachment 8456523 [details] [diff] [review]
part 3 - Use an nsRefPtr for CrossProcessMutex::mSharedBuffer.
Attachment #8456523 - Flags: review?(bjacob)
(Assignee)

Comment 4

4 years ago
hmm I'll ditch the |mBuffer = nullptr;| in the second patch...
Attachment #8456521 - Flags: review?(bjacob) → review+
Attachment #8456522 - Flags: review?(bjacob) → review+
Attachment #8456523 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/f60bdae3c097
https://hg.mozilla.org/mozilla-central/rev/2bf6c098623d
https://hg.mozilla.org/mozilla-central/rev/74034d6b6ae6
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.