Closed Bug 1038986 Opened 11 years ago Closed 7 years ago

[email/backend] Rename MailHeader.getBody's downloadBodyReps and withBodyReps args for clarity

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: asuth, Unassigned)

Details

withBodyReps waits for the body parts to be downloaded before returning the body object. downloadBodyReps returns the body object ASAP and then triggers background downloading of the body parts. The difference in names is subtle enough for me that I keep suspecting the flag instead of other possible problems when the distinction fades for me. I propose the following changes: - downloadBodyReps to downloadBodyRepsInBackground - withBodyReps to downloadAndWaitForBodyReps While they're not completely self-explanatory (you still need to read the getBody comment block), I think it's unlikely I or anyone who understands the option space would confuse one for the other.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.