1038990 - Add a border on both side of the tab bar when using a lightweight theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Zhenshuo Fang (:fang) - Firefox UX Team]

+++ This bug was initially created as a clone of Bug #1015157 +++

Implement the solution in bug 1015157 on Windows 7 & 8

Comment 1

[Matthew N. [:MattN]]

Note that it's possible that bug 672885 (blocking bug 590945) is not an issue for Windows 8 (which uses newer DirectX) so we may be able to do Window frame stuff (like bug 590945) for Win8+.

Comment 2

[:Gijs (he/him)]

If I read bug 1015157 comment 6 correctly, the only thing we need to do here is add a grey border to the left and right side of the tab bar. Philipp, is that right?

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch from comment #2)
> If I read bug 1015157 comment 6 correctly, the only thing we need to do here
> is add a grey border to the left and right side of the tab bar. Philipp, is
> that right?

Yes that's the main thing. Note that this is only for Windows 7 and 8 though.
I just saw that Zhenshuo didn't include a mockup for Windows XP in the bug (round corners on the theme would be really helpful there), but I can find that.

Comment 4

[Dão Gottwald [:dao]]

Attachment: lwtborder.diff

Comment 5

[Dão Gottwald [:dao]]

Attachment: lwtborder.diff

Hmm, I'm not sure if ::after:not(:-moz-lwtheme) works. Changed to :not(:-moz-lwtheme)::after.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff

Review of attachment 8493688 [details] [diff] [review]:
-----------------------------------------------------------------

With my apologies for the delay here.

This looks kind of awkward in the top-left corner because of the top border we use for lwthemes... but I'm not really sure how to fix that, and I think this is a strict improvement, so let's at least take this.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/3fe1a3795cb7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3fe1a3795cb7

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on latest Nightly, build ID: 20140925030203

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff

Approval Request Comment
[Feature/regressing bug #]: part of the effort to promote lightweight themes in customization mode
[User impact if declined]: see bug 1015157 comment 6 (first point)
[Describe test coverage new/current, TBPL]: no tests
[Risks and why]: small CSS-only change, low risk
[String/UUID change made/needed]: none

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff

Aurora+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbccaaa0ada9

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Verified on Nightly in comment 9.

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (X11; Linux i686; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0

Verified fixed on latest Aurora, build ID: 20140930004006.