Add a border on both side of the tab bar when using a lightweight theme

VERIFIED FIXED in Firefox 34

Status

()

Firefox
Theme
VERIFIED FIXED
3 years ago
a year ago

People

(Reporter: fang, Assigned: dao)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 35
All
Windows
Points:
5
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox34 verified, firefox35 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1015157 +++

Implement the solution in bug 1015157 on Windows 7 & 8
Flags: firefox-backlog+

Updated

3 years ago
Points: --- → 5
QA Whiteboard: [qa+]
Note that it's possible that bug 672885 (blocking bug 590945) is not an issue for Windows 8 (which uses newer DirectX) so we may be able to do Window frame stuff (like bug 590945) for Win8+.

Updated

3 years ago
QA Whiteboard: [qa+]
Flags: qe-verify+

Comment 2

3 years ago
If I read bug 1015157 comment 6 correctly, the only thing we need to do here is add a grey border to the left and right side of the tab bar. Philipp, is that right?
Flags: needinfo?(philipp)
(In reply to :Gijs Kruitbosch from comment #2)
> If I read bug 1015157 comment 6 correctly, the only thing we need to do here
> is add a grey border to the left and right side of the tab bar. Philipp, is
> that right?

Yes that's the main thing. Note that this is only for Windows 7 and 8 though.
I just saw that Zhenshuo didn't include a mockup for Windows XP in the bug (round corners on the theme would be really helpful there), but I can find that.
Flags: needinfo?(philipp)

Updated

3 years ago
Assignee: nobody → dao
Status: NEW → ASSIGNED
Iteration: --- → 35.2

Updated

3 years ago
QA Contact: cornel.ionce
(Assignee)

Updated

3 years ago
Component: Toolbars and Customization → Theme
(Assignee)

Comment 4

3 years ago
Created attachment 8493687 [details] [diff] [review]
lwtborder.diff
Attachment #8493687 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Comment 5

3 years ago
Created attachment 8493688 [details] [diff] [review]
lwtborder.diff

Hmm, I'm not sure if ::after:not(:-moz-lwtheme) works. Changed to :not(:-moz-lwtheme)::after.
Attachment #8493687 - Attachment is obsolete: true
Attachment #8493687 - Flags: review?(gijskruitbosch+bugs)
Attachment #8493688 - Flags: review?(gijskruitbosch+bugs)

Comment 6

3 years ago
Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff

Review of attachment 8493688 [details] [diff] [review]:
-----------------------------------------------------------------

With my apologies for the delay here.

This looks kind of awkward in the top-left corner because of the top border we use for lwthemes... but I'm not really sure how to fix that, and I think this is a strict improvement, so let's at least take this.
Attachment #8493688 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/3fe1a3795cb7
Hardware: x86 → All
Summary: Implement quick visual fixes for lightweight theme display on Windows → Add a border on both side of the tab bar when using a lightweight theme
https://hg.mozilla.org/mozilla-central/rev/3fe1a3795cb7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified fixed on latest Nightly, build ID: 20140925030203
Status: RESOLVED → VERIFIED
(Assignee)

Comment 10

3 years ago
Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff

Approval Request Comment
[Feature/regressing bug #]: part of the effort to promote lightweight themes in customization mode
[User impact if declined]: see bug 1015157 comment 6 (first point)
[Describe test coverage new/current, TBPL]: no tests
[Risks and why]: small CSS-only change, low risk
[String/UUID change made/needed]: none
Attachment #8493688 - Flags: approval-mozilla-aurora?
Comment on attachment 8493688 [details] [diff] [review]
lwtborder.diff

Aurora+
Attachment #8493688 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox34: --- → affected
status-firefox35: --- → fixed
https://hg.mozilla.org/releases/mozilla-aurora/rev/bbccaaa0ada9
status-firefox34: affected → fixed
Verified on Nightly in comment 9.
status-firefox35: fixed → verified
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (X11; Linux i686; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0

Verified fixed on latest Aurora, build ID: 20140930004006.
status-firefox33: --- → verified
status-firefox33: verified → ---
status-firefox34: fixed → verified
Blocks: 1075435
(Assignee)

Updated

3 years ago
No longer blocks: 1075435
Depends on: 1075435
(Assignee)

Updated

a year ago
OS: All → Windows
You need to log in before you can comment on or make changes to this bug.