Closed Bug 1039128 Opened 7 years ago Closed 6 years ago

MP4Reader doesn't reach end of avatar.mp4 on Windows

Categories

(Core :: Audio/Video, defect)

29 Branch
x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: cpearce, Assigned: ajones)

References

Details

Attachments

(1 file)

When I play http://people.mozilla.org/~cpearce/avatar.mp4 with the MP4Reader on Windows, we don't play all the way to the end of the video stream. It's supposed to end with a few black frames, but playback stops still showing so "December 18th" text.

This is despite me having the patch for bug 973710 in my tree.
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Comment on attachment 8462262 [details] [diff] [review]
Fix drain of video queue

Review of attachment 8462262 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/fmp4/PlatformDecoderModule.h
@@ +129,5 @@
>    // Denotes that the last input sample has been inserted into the decoder,
>    // and no more output can be produced unless more input is sent.
>    virtual void InputExhausted() = 0;
> +
> +  virtual void DrainComplete() = 0;

The comments are now out of date.

Please replace the following comment on MediaDataDecoder::Drain() below:

  // This function is synchronous. Once it's returned, all samples to be
  // output should have been returned via callback to the MP4Reader.

with:

  // This function is asynchronous. The MediaDataDecoder must call 
  // MediaDataDecoderCallback::DrainComplete() once all remaining
  // samples have been output.
Attachment #8462262 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/27fb335105ef
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Blocks: 1046301
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.