1039187 - [Bluetooth] Bluetooth2 build fail

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Since yesterday, Bluetooth2 builds fail with 

> In file included from LocationBinding.cpp:3:0,
>                  from UnifiedBindings17.cpp:2:
> ../../dist/include/mozilla/dom/LocationBinding.h: In function 'bool mozilla::dom::LocationBinding::IsPermitted(JSFlatString*, jschar, bool)':
> ../../dist/include/mozilla/dom/LocationBinding.h:68:57: error: 'JS_FlatStringEqualsAscii' was not declared in this scope
> ../../dist/include/mozilla/dom/LocationBinding.h:74:61: error: 'JS_FlatStringEqualsAscii' was not declared in this scope

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

When I apply 'new-api.patch', builds fail. The current Bluetooth module works.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I can work around the problem by including 'jsapi.h' in 'LocationBinding.h'.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: newapi-config.patch

Patch to enable building Bluetooth2.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Jocelyn found that this problem might have been introduced by bug 832014.

Comment 5

[Jocelyn Liu [:jocelyn] [:joliu]]

Just a finding to share, LocationBinding.h can use JS_FlatStringEqualsAscii without include 'jsapi.h' if we didn't apply our newapi-config.patch.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hmm.  This is presumably the IsPermitted method.  We could make it out-of-line if that's OK perf wise; else we need to twiddle includes.

Comment 7

[Bobby Holley (:bholley)]

Making it out-of-line is probably fine, I think.

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: v1

This keeps it inline but fixes the headers. Let me know if you prefer I do the uninlining instead. diff -w coming up.

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: v1 (diff -w)

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8458311 [details] [diff] [review]
v1

>+            elif descriptor.needsSpecialGenericOps():
>+                props.isSetter = True
>+        elif m.getExtendedAttribute("Replaceable"):
>+            if descriptor.needsSpecialGenericOps():
>+                props.isSetter = True

Those should both be isGenericSetter, no?

r=me with that fixed

Comment 12

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e53c1891fd6b

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e53c1891fd6b