1039191 - Automatically test the sample configuration during tests

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Alexis Metaireau (:alexis)]

We should automatically test that the sample file is valid, by passing it to the config.js logic during the tests.

Comment 1

[Rémy Hubscher (:natim)]

Attachment: Link to github PR

Comment 2

[James Bonacci [:jbonacci]]

So https://github.com/mozilla-services/loop-server/pull/174 has been merged.
Can this bug be considered Resolved/Fixed?

Comment 3

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/6c911f44fe7e8aa762cd27aa27c9162e44f19a5f

Comment 4

[Alexis Metaireau (:alexis)]

Comment on attachment 8474483 [details] [review]
Link to github PR

Already reviewed and merged.

Comment 5

[James Bonacci [:jbonacci]]

Yep.
$ make test

> mozilla-msisdn-gateway@0.5.0-DEV lint /Users/James/msisdn-gateway
> eslint msisdn-gateway test tools

[2014-08-19 18:13:58] INFO  WEBrick 1.3.1
[2014-08-19 18:13:58] INFO  ruby 2.0.0 (2014-02-24) [universal.x86_64-darwin13]
== Sinatra/1.4.5 has taken the stage on 4567 for production with backup from WEBrick
[2014-08-19 18:13:58] INFO  WEBrick::HTTPServer#start: pid=1187 port=4567


Server listening on http://127.0.0.1:5000
  config
    #validateKeys
      ✓ should throw an error if a key is missing 
      ✓ should not throw if all keys are valid 
    #hexKeyOfSize
      ✓ should check if all chars are hexadecimals 
      ✓ should check the size of the given key 
    sample.json
      ✓ should load.
...etc..