Closed Bug 1039201 Opened 5 years ago Closed 5 years ago

[User Story] Search results in grid only format

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.1, b2g-v2.0 wontfix, b2g-v2.1 affected)

RESOLVED FIXED
2.0 S6 (18july)
feature-b2g 2.1
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.1 --- affected

People

(Reporter: pdol, Assigned: kgrandon)

References

Details

(Keywords: feature, Whiteboard: [ucid:System231], [systemsfe][tako])

User Story

As a user I want me search results to be displayed in a grid only format to make my experience much more consistent.

Acceptance Criteria:
1. Search results in Rocketbar are displayed in a grid format, per the UX spec.
2. The top search result per domain from History is only presented with a single icon, per UX spec.
3. A maximum number of four results (representing four domains) is shown at a time, per UX spec.

Attachments

(1 file)

46 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review
No description provided.
Assignee: nobody → dale
Blocks: rocketbar-dogfood
No longer blocks: rocketbar-search-mvp
Ill work on this, but not at this moment so deassigning
Assignee: dale → nobody
I know this pretty well, so I'll take it.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0 S6 (18july)
Attached file Github pull request
Trade you the review Dale? :)

-8 lines of code, woot.
Attachment #8458762 - Flags: review?(dale)
Comment on attachment 8458762 [details] [review]
Github pull request

Linting and unit tests that need fixed before landing, but looks great, cheers
Attachment #8458762 - Flags: review?(dale) → review+
Issues resolved. Dumbed down a unit test because we now use the grid to render, so asserting on the provider return objects should suffice.

Master: https://github.com/mozilla-b2g/gaia/commit/30e89e6711a1838a8cd6fdaa7215f2e313b7795d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
Whiteboard: [ucid:System231], [ft:systemsfe] → [ucid:System231], [systemsfe][tako]
You need to log in before you can comment on or make changes to this bug.