This is just a minor problem I noticed while examining our build log on Solaris. On 32-bit Solaris SPARC Edition, NSS files are compiled with -xarch=v8, with the following exceptions. - One file (freebl/loader.c) is (mistakenly?) compiled with -xarch=v8 -xchip=ultra2. - libfreebl_hybrid_3.so is compiled with -xarch=v8plus or -xarch=v8plusa and -xchip=ultra2. The following makefile fragment from freebl/Makefile is incorrect. There are three cases when compiling freebl files. 1. Default. Neither USE_PURE_32 nor USE_HYBRID is defined. freebl/loader.c belongs to this case. 2. Pure32. USE_PURE_32 is defined. 3. Hybrid. USE_HYBRID is defined. The makefile in freebl says: ifndef USE_PURE_32 OS_CFLAGS += -xchip=ultra2 endif This is why not only the "hybrid" case but also the "default" case (freebl/loader.c) is compiled with -xchip=ultra2. I think the intention is that only the "hybrid" case should be compiled with -xchip=ultra2. Therefore the above should be changed to: ifdef USE_HYBRID OS_CFLAGS += -xchip=ultra2 endif
Nelson, could you review my patch?
The patch was checked in on the tip and the NSS_3_3_BRANCH of NSS. The NSS_CLIENT_TAG was moved to include the fix.