freebl/loader.c is compiled with the -xchip=ultra2 flag.

RESOLVED FIXED in 3.3.2

Status

NSS
Build
P2
minor
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

3.3.1
3.3.2
Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
This is just a minor problem I noticed while examining
our build log on Solaris.

On 32-bit Solaris SPARC Edition, NSS files are compiled
with -xarch=v8, with the following exceptions.
- One file (freebl/loader.c) is (mistakenly?) compiled with
  -xarch=v8 -xchip=ultra2.
- libfreebl_hybrid_3.so is compiled with -xarch=v8plus or
  -xarch=v8plusa and -xchip=ultra2.

The following makefile fragment from freebl/Makefile is
incorrect.

There are three cases when compiling freebl files.
1. Default.  Neither USE_PURE_32 nor USE_HYBRID is
   defined.  freebl/loader.c belongs to this case.
2. Pure32.  USE_PURE_32 is defined.
3. Hybrid.  USE_HYBRID is defined.

The makefile in freebl says:

ifndef USE_PURE_32
    OS_CFLAGS += -xchip=ultra2
endif

This is why not only the "hybrid" case but also the
"default" case (freebl/loader.c) is compiled with
-xchip=ultra2.  I think the intention is that only
the "hybrid" case should be compiled with -xchip=ultra2.
Therefore the above should be changed to:

ifdef USE_HYBRID
    OS_CFLAGS += -xchip=ultra2
endif
(Assignee)

Comment 1

16 years ago
Created attachment 52783 [details] [diff] [review]
Proposed patch.
(Assignee)

Updated

16 years ago
Priority: -- → P2
Target Milestone: --- → 3.4
(Assignee)

Comment 2

16 years ago
Nelson, could you review my patch?
Status: NEW → ASSIGNED
r=nelsonb
(Assignee)

Comment 4

16 years ago
The patch was checked in on the tip and the
NSS_3_3_BRANCH of NSS.  The NSS_CLIENT_TAG
was moved to include the fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: 3.4 → 3.3.2
You need to log in before you can comment on or make changes to this bug.