Closed Bug 1039452 Opened 10 years ago Closed 10 years ago

Near-perma orange: TEST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird33 fixed, thunderbird34 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 35.0
Tracking Flags:
Tracking Status
thunderbird33 --- fixed
thunderbird34 --- fixed

People

(Reporter: mkmelin, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

bug1039452.patch
2.24 KB, patch
standard8
: review+
standard8
: approval-comm-aurora+
standard8
: approval-comm-beta+
Details | Diff | Splinter Review 
Seeing this on linux only it seems

SUMMARY-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder
  EXCEPTION: Popup never opened! id=button-attachPopup, state=showing
    at: utils.js line 447
       TimeoutError utils.js:447 13
       waitFor utils.js:485 1
       _click_menus test-window-helpers.js:960 1
       assert_manual_reminder_state test-attachment-reminder.js:76 25
       test_manual_attachment_reminder test-attachment-reminder.js:274 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 10
       Bridge.prototype.execFunction server.js:183 16
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3

https://tbpl.mozilla.org/php/getParsedLog.php?id=43865122&tree=Thunderbird-Trunk&full=1
Summary: SUMMARY-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder → TEST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder
Depends on: 1039453
This is now nearly permanent orange (extremely frequent, more hits than misses).
Summary: TEST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder → Near-perma orange: TEST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder
Is this failure a timing issue?
Sometimes it fails for me on line with the same error though.
And, on a re-run, it passes for me successfully.
I'm on linux.

So, how do we address such timing issue bugs? Do we increase the script
timeout value?
Attached patch bug1039452.patch — — Splinter Review 
This patch does not fix failures completely especially on linux64 opt build but reduces the frequency.

Try server results:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3c9b58cbd6ac
Attachment #8485485 - Flags: review?(standard8)
Looks like the permanent problems with focus in mozmill on Linux.
Comment on attachment 8485485 [details] [diff] [review]
bug1039452.patch

Review of attachment 8485485 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this seems to help a lot, lets get this landed, and we can always add more improvements later.
Attachment #8485485 - Flags: review?(standard8) → review+
I am sorry the patch contains try server syntax.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/39cdeeaee00f
Assignee: nobody → hiikezoe
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 35.0
Comment on attachment 8485485 [details] [diff] [review]
bug1039452.patch

Review of attachment 8485485 [details] [diff] [review]:
-----------------------------------------------------------------

Also pushed to aurora & beta:

https://hg.mozilla.org/releases/comm-aurora/rev/e186316c0430
https://hg.mozilla.org/releases/comm-beta/rev/7a9679f99e14
Attachment #8485485 - Flags: approval-comm-beta+
Attachment #8485485 - Flags: approval-comm-aurora+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1070665
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: