Closed Bug 1039453 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | test-charset-edit.js | test-charset-edit.js::test_wrong_reply_charset + test-charset-edit.js::test_no_mojibake

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird33 fixed, thunderbird34 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 35.0
Tracking Flags:
Tracking Status
thunderbird33 --- fixed
thunderbird34 --- fixed

People

(Reporter: mkmelin, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

The patch
1.14 KB, patch
standard8
: review+
standard8
: approval-comm-aurora+
standard8
: approval-comm-beta+
Details | Diff | Splinter Review 
SUMMARY-UNEXPECTED-FAIL | test-charset-edit.js | test-charset-edit.js::test_wrong_reply_charset
  EXCEPTION: a != b: 'utf-8' != 'windows-1252'.
    at: test-folder-display-helpers.js line 2850
       assert_true test-folder-display-helpers.js:2850 11
       assert_equals test-folder-display-helpers.js:2837 3
       test_wrong_reply_charset test-charset-edit.js:112 1
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 10
       Bridge.prototype.execFunction server.js:183 16
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3
SUMMARY-UNEXPECTED-FAIL | test-charset-edit.js | test-charset-edit.js::test_no_mojibake
  EXCEPTION: a != b: 'x-mac-croatian' != 'utf-7'.
    at: test-folder-display-helpers.js line 2850
       assert_true test-folder-display-helpers.js:2850 11
       assert_equals test-folder-display-helpers.js:2837 3
       test_no_mojibake test-charset-edit.js:141 1
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 10
       Bridge.prototype.execFunction server.js:183 16
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3

https://tbpl.mozilla.org/php/getParsedLog.php?id=43865122&tree=Thunderbird-Trunk&full=1
Very charset related...
Looking at arbpl I think this looks to be just a consequence of the attachment reminder issues (bug 1039452 / bug 1039714)
The draft message we select to check the charset of is apparently an auto-saved draft from one of those tests which times out... Subjct is is "Testing manual reminder"
Blocks: 1039452
Magnus is right. I will attach a patch soon.
Attached patch The patch — — Splinter Review 
Try server results:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=f2f49a358ba1
Assignee: nobody → hiikezoe
Attachment #8483861 - Flags: review?(standard8)
Attachment #8483861 - Flags: review?(standard8) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2a0931247e63
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 35.0
Comment on attachment 8483861 [details] [diff] [review]
The patch

[Triage Comment]
Taking to aurora and beta to help fix bustage there.
Attachment #8483861 - Flags: approval-comm-beta+
Attachment #8483861 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: